Skip to contentSkip to conversation

devfs_remove call when not using devfs 2.6.0-test1

DISCUSSION Balram Adlakha 2 participants 2 messages Jul 24, 2003 – Jul 26, 2003 Sound

lore
Share & tools
lore
#0 lore raw

I get the following when I remove the OSS emu10k1 module:

 Call Trace:
[<c018e261>] devfs_remove+0x9e/0xa0
[<c013898a>] unmap_vmas+0xcb/0x214
[<d29e3e2d>] oss_cleanup+0x2b/0xed [sound]
[<c0129c1e>] sys_delete_module+0x152/0x1a8
[<c0130064>] generic_file_aio_write_nolock+0x8a7/0xa6a
[<c013be3c>] sys_munmap+0x57/0x75
[<c0108f81>] sysenter_past_esp+0x52/0x71

I'm not using devfs so it should not happen.

#1 lore raw
Quoted 12 lines · Balram Adlakha

I get the following when I remove the OSS emu10k1 module:

 Call Trace:
[<c018e261>] devfs_remove+0x9e/0xa0
[<c013898a>] unmap_vmas+0xcb/0x214
[<d29e3e2d>] oss_cleanup+0x2b/0xed [sound]
[<c0129c1e>] sys_delete_module+0x152/0x1a8
[<c0130064>] generic_file_aio_write_nolock+0x8a7/0xa6a
[<c013be3c>] sys_munmap+0x57/0x75
[<c0108f81>] sysenter_past_esp+0x52/0x71
Quoted 1 line

I'm not using devfs so it should not happen.

Does this fix it?

sound/oss/soundcard.c renamed from sound/oss/soundcard.c~soundcard-devfs-fix +1 -1
diff -puN sound/oss/soundcard.c~soundcard-devfs-fix sound/oss/soundcard.c
@@ -592,7 +592,7 @@ static void __exit oss_cleanup(void)
 	int i, j;
 
 	for (i = 0; i < sizeof (dev_list) / sizeof *dev_list; i++) {
-		devfs_remove("snd/%s", dev_list[i].name);
+		devfs_remove("sound/%s", dev_list[i].name);
 		if (!dev_list[i].num)
 			continue;
 		for (j = 1; j < *dev_list[i].num; j++)

_