Skip to contentSkip to conversation

more callbacks for pci powermanagment

PM Pavel Machek 2 participants 2 messages Jul 26, 2003 – Aug 5, 2003 PCI

lore
Share & tools
lore
#0 lore raw

Hi!

Some PCI devices need to act during power-on... Greg refused to apply it waiting for you, but you probably remember that discussion.

Pavel

drivers/pci/pci-driver.c +3 -5
Index: linux/drivers/pci/pci-driver.c
===================================================================
@@ -179,11 +179,9 @@
 	struct pci_dev * pci_dev = to_pci_dev(dev);
 
 	if (pci_dev->driver) {
-		/* We may not call PCI drivers resume at
-		   RESUME_POWER_ON because interrupts are not yet
-		   working at that point. Calling resume at
-		   RESUME_RESTORE_STATE seems like solution. */
-		if (level == RESUME_RESTORE_STATE && pci_dev->driver->resume)
+	        if (level == RESUME_POWER_ON && pci_dev->driver->power_on)
+			pci_dev->driver->power_on(pci_dev);
+		else if (level == RESUME_RESTORE_STATE && pci_dev->driver->resume)
 			pci_dev->driver->resume(pci_dev);
 	}
 	return 0;
include/linux/pci.h +1 -0
Index: linux/include/linux/pci.h
===================================================================
@@ -512,6 +512,7 @@
 	void (*remove) (struct pci_dev *dev);	/* Device removed (NULL if not a hot-plug capable driver) */
 	int  (*save_state) (struct pci_dev *dev, u32 state);    /* Save Device Context */
 	int  (*suspend) (struct pci_dev *dev, u32 state);	/* Device suspended */
+	int  (*power_on) (struct pci_dev *dev);	                /* Device power on */
 	int  (*resume) (struct pci_dev *dev);	                /* Device woken up */
 	int  (*enable_wake) (struct pci_dev *dev, u32 state, int enable);   /* Enable wake event */
 
Signature · 2 lines
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
#1 lore raw
Quoted 3 lines

Some PCI devices need to act during power-on... Greg refused to apply it waiting for you, but you probably remember that discussion.

I do remember, and am holding off on this for a few days until I have a chance to do some of the necessary PM infrastructure to support this globally.

-pat