O12.3 for interactivity

PATCH New Con Kolivas 1 participant 1 message Aug 4, 2003

Share & tools

Con Kolivas

author

2003-08-04 11:44 UTC #0 lore raw

PATCH 1/1 O12.3 for interactivity

Here is a small patch against O12.2. This should not change peformance in any way but removes redundant code (which we all love to do). Ingo pointed out that new forks wont have any sleep time to earn as sleep_avg. It is also extrememly unlikely that there won't be any sleep time with nanosecond timing. Patch applies to 2.6.0-test2-mm4 or test2 patched with O12.2.

Con

kernel/sched.c +1 -9

diff -Naurp linux-2.6.0-test2-mm4/kernel/sched.c linux-2.6.0-test2-mm4-O12.3/kernel/sched.c
@@ -365,9 +365,6 @@ static void recalc_task_prio(task_t *p, 
 	unsigned long long __sleep_time = now - p->timestamp;
 	unsigned long sleep_time;
 
-	if (unlikely(!p->timestamp))
-		__sleep_time = 0;
-
 	if (__sleep_time > NS_MAX_SLEEP_AVG)
 		sleep_time = NS_MAX_SLEEP_AVG;
 	else

@@ -420,8 +417,7 @@ static void recalc_task_prio(task_t *p, 
 				p->interactive_credit++;
 			}
 		}
-	} else if (!p->sleep_avg)
-		p->interactive_credit--;
+	}
 
 	p->prio = effective_prio(p);
 }

@@ -454,9 +450,6 @@ static inline void activate_task(task_t 
 	 */
 		p->activated = 1;
 
-	if (unlikely(!p->timestamp))
-		p->activated = 0;
-
 	p->timestamp = now;
 
 	__activate_task(p, rq);

@@ -644,7 +637,6 @@ void wake_up_forked_process(task_t * p)
 	p->sleep_avg = JIFFIES_TO_NS(sleep_avg);
 
 	p->interactive_credit = 0;
-	p->timestamp = 0;
 
 	p->prio = effective_prio(p);
 	set_task_cpu(p, smp_processor_id());