Skip to contentSkip to conversation

Fixes ac3 passthru non-audio bit setting for AC97 codecs.

PATCH In review James Courtier-Dutton 3 participants 6 messages Aug 14, 2003

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fixes ac3 passthru non-audio bit setting for AC97 codecs.

I have :-
Card: Intel ICH5
Chip: Avance Logic ALC650 rev 0

The problem I was having was that the spdif "non-audio" bit was not being set. This patch fixes that problem.

Cheers
James

ac97_codec.c renamed from ac97_codec.c.org +6 -0
@@ -823,7 +825,13 @@
 					       AC97_CXR_SPDIF_MASK | AC97_CXR_COPYRGT,
 					       v);
 	} else {
+		unsigned short extst = ac97->regs[AC97_EXTENDED_STATUS];
+		snd_ac97_update_bits(ac97, AC97_EXTENDED_STATUS, AC97_EA_SPDIF, 0); /* turn off */
+
 		change |= snd_ac97_update_bits(ac97, AC97_SPDIF, 0x3fff, val);
+		if (extst & AC97_EA_SPDIF) {
+			snd_ac97_update_bits(ac97, AC97_EXTENDED_STATUS, AC97_EA_SPDIF, AC97_EA_SPDIF); /* turn on again */
+                }
 	}
 
 	return change;
#1 lore raw

At Thu, 14 Aug 2003 16:16:03 +0100,

Quoted 8 lines · James Courtier-Dutton

I have :-
Card: Intel ICH5
Chip: Avance Logic ALC650 rev 0

The problem I was having was that the spdif "non-audio" bit was not being set.
This patch fixes that problem.

thanks, now applied to cvs.

Takashi

-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01

#2 lore raw
Quoted 5 lines · Takashi Iwai
Quoted 3 lines

The problem I was having was that the spdif "non-audio" bit was not being set.
This patch fixes that problem.

thanks, now applied to cvs.

Is there any hope to do the same for the cs46xx?

Thank you very much,

Grégoire
__________________________________________________________________
http://www-ima.unil.ch/greg ICQ:16624071 mailto:[email protected]

-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01

#3 lore raw

At Thu, 14 Aug 2003 18:49:13 +0200,

Quoted 10 lines · Gregoire Favre
Quoted 5 lines · Takashi Iwai
Quoted 3 lines

The problem I was having was that the spdif "non-audio" bit was not being set.
This patch fixes that problem.

thanks, now applied to cvs.

Is there any hope to do the same for the cs46xx?

the hardware is completely different...

anyway, please give a try the following patch.

Takashi

#4 lore raw
In reply to Gregoire Favre
Quoted 9 lines · Gregoire Favre
Quoted 4 lines · Takashi Iwai
Quoted 2 lines

The problem I was having was that the spdif "non-audio" bit was not being set. This patch fixes that problem.

thanks, now applied to cvs.

Quoted 9 lines

Is there any hope to do the same for the cs46xx?

Thank you very much,

Grégoire
__________________________________________________________________
http://www-ima.unil.ch/greg ICQ:16624071 mailto:[email protected]

I don't know if I can help or not, because I don't have that sound card. If you can send me the output of :-
lspci -v
lspci -vn
alsamixer <- What is the name of the Card: and Chip: ?

I will see what I can do.

Cheers
James

-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01

#5 lore raw
Quoted 7 lines · James Courtier-Dutton

I don't know if I can help or not, because I don't have that sound card. If you can send me the output of :-
lspci -v
lspci -vn
alsamixer <- What is the name of the Card: and Chip: ?

I will see what I can do.

Thank you very much, as soon as I will open my computer and change the SBlive for the Hercule ones and send you the requested info ;-)

Have a great day,

Grégoire
__________________________________________________________________
http://www-ima.unil.ch/greg ICQ:16624071 mailto:[email protected]

-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01