bugfix for initialization bug in adm1021 driver

PATCH Applied Rusty Lynch 3 participants 3 messages Aug 13, 2003 – May 19, 2005

Share & tools

Rusty Lynch

author

2003-08-13 00:04 UTC #0 lore raw

PATCH 1/1 bugfix for initialization bug in adm1021 driver

While initializing the adm1021 device, the driver is performing a conversion from fixed point to Celcius on values that were declaired as Celcius. On my Dell Precision 220 this results in a shutdown after a couple of minutes running.

This is a very simple patch against the 2.6.0-test3 tree that just removes the conversion.

--rustyl

drivers/i2c/chips/adm1021.c +4 -4

diff -urN linux-2.6.0-test3/drivers/i2c/chips/adm1021.c linux-2.6.0-test3-patched/drivers/i2c/chips/adm1021.c
@@ -356,13 +356,13 @@
 {
 	/* Initialize the adm1021 chip */
 	adm1021_write_value(client, ADM1021_REG_TOS_W,
-			    TEMP_TO_REG(adm1021_INIT_TOS));
+			    adm1021_INIT_TOS);
 	adm1021_write_value(client, ADM1021_REG_THYST_W,
-			    TEMP_TO_REG(adm1021_INIT_THYST));
+			    adm1021_INIT_THYST);
 	adm1021_write_value(client, ADM1021_REG_REMOTE_TOS_W,
-			    TEMP_TO_REG(adm1021_INIT_REMOTE_TOS));
+			    adm1021_INIT_REMOTE_TOS);
 	adm1021_write_value(client, ADM1021_REG_REMOTE_THYST_W,
-			    TEMP_TO_REG(adm1021_INIT_REMOTE_THYST));
+			    adm1021_INIT_REMOTE_THYST);
 	/* Enable ADC and disable suspend mode */
 	adm1021_write_value(client, ADM1021_REG_CONFIG_W, 0);
 	/* Set Conversion rate to 1/sec (this can be tinkered with) */

Greg KH

Applied

2003-08-14 21:32 UTC #1 lore raw

Quoted 7 lines · Rusty Lynch

While initializing the adm1021 device, the driver is performing a conversion from fixed point to Celcius on values that were declaired as Celcius. On my Dell Precision 220 this results in a shutdown after a couple of minutes running.
This is a very simple patch against the 2.6.0-test3 tree that just removes the conversion.

Applied, thanks.

Next time you might want to CC: me to make sure I catch this.

greg k-h

Jean Delvare

2005-05-19 06:24 UTC #2 lore raw

PATCH 1/1 bugfix for initialization bug in adm1021

In reply to Rusty Lynch

Quoted 10 lines

Quoted 8 lines
While initializing the adm1021 device, the driver is performing a conversion from fixed point to Celcius on values that were declaired as Celcius. On my Dell Precision 220 this results in a shutdown after a couple of minutes running.
This is a very simple patch against the 2.6.0-test3 tree that just removes the conversion.
Applied, thanks.

I just checked and this does not apply to our CVS tree. The bug was introduced by the sysfs conversion (because millidegrees are in use there, while these are degrees in CVS).

Signature · 2 lines

Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/