noapic should depend on ioapic config not local

Zwane's comment was correct, it needs to be CONFIG_X86_IO_APIC.

IMO this stuff really wants to be moved to __setup(), to clean up the ifdefs and modularize the code.

===== arch/i386/kernel/setup.c 1.93 vs edited =====

@@ -543,12 +543,12 @@
 			if (!acpi_force) acpi_disabled = 1;
 		}
 
-#ifdef CONFIG_X86_LOCAL_APIC
+#ifdef CONFIG_X86_IO_APIC
 		/* disable IO-APIC */
 		else if (!memcmp(from, "noapic", 6)) {
 			skip_ioapic_setup = 1;
 		}
-#endif /* CONFIG_X86_LOCAL_APIC */
+#endif /* CONFIG_X86_IO_APIC */
 #endif /* CONFIG_ACPI_BOOT */
 
 		/*

Does this also apply to 2.4.22-rc2?

I must use noapic on my system and 2.4.22 does ignore it, while 2.4.21 doesn't.

Regards

Ingo Oeser

Marcelo just pulled a bunch of ACPI fixes, so I would check the latest BK, or wait for tonight's BK snapshot.

So, yes, it does apply to 2.4.22-rc2, but the Intel guys may have taken care of it already.

Jeff