Skip to contentSkip to conversation

'noapic' already handled elsewhere

PATCH New Jeff Garzik 1 participant 1 message Aug 21, 2003

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 'noapic' already handled elsewhere

I sent a previous patch to s/LOCAL_APIC/IO_APIC/, as Zwane noticed my first patch needed that. In that patch, I commented __setup() would be better.

Well... line 718 of arch/i386/kernel/io_apic.c _already_ handles this case, using __setup() properly.

Word of warning... patch only compile tested, but seems obvious from looking at io_apic.c.

BTW, why isn't ACPI using __setup() as well? I don't see that ACPI needs to patch arch/i386/kernel/setup.c at all.

===== arch/i386/kernel/setup.c 1.94 vs edited =====

arch/i386/kernel/setup.c +0 -6
@@ -544,12 +544,6 @@
 			if (!acpi_force) acpi_disabled = 1;
 		}
 
-#ifdef CONFIG_X86_LOCAL_APIC
-		/* disable IO-APIC */
-		else if (!memcmp(from, "noapic", 6)) {
-			skip_ioapic_setup = 1;
-		}
-#endif /* CONFIG_X86_LOCAL_APIC */
 #endif /* CONFIG_ACPI_BOOT */
 
 		/*