Skip to contentSkip to conversation

Remaining task queue to work queue conversion.

PATCH-2.6.0-test4-bk1 Krishnakumar. R 1 participant 1 message Aug 24, 2003 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

Dear Linus and all,

Somewhere in the transition of task queue to the work queue, in stallion.c, some of the schedule_task were
left out from being converted to schedule_work. The following patch solves the problem.

Without this the drivers/char/stallion.c
cannot be compiled as part of the kernel (make bzImage).

Please do apply!

Regards
KK

============================
The following is the patch:

drivers/char/stallion.c renamed from drivers/char/stallion.orig.c +3 -3
@@ -4234,7 +4234,7 @@
 	misr = inb(ioaddr + EREG_DATA);
 	if (misr & MISR_DCD) {
 		set_bit(ASYI_DCDCHANGE, &portp->istate);
-		schedule_task(&portp->tqueue);
+		schedule_work(&portp->tqueue);
 		portp->stats.modem++;
 	}
 
@@ -5031,7 +5031,7 @@
 	if ((len == 0) || ((len < STL_TXBUFLOW) &&
 	    (test_bit(ASYI_TXLOW, &portp->istate) == 0))) {
 		set_bit(ASYI_TXLOW, &portp->istate);
-		schedule_task(&portp->tqueue); 
+		schedule_work(&portp->tqueue); 
 	}
 
 	if (len == 0) {
@@ -5248,7 +5248,7 @@
 		ipr = stl_sc26198getreg(portp, IPR);
 		if (ipr & IPR_DCDCHANGE) {
 			set_bit(ASYI_DCDCHANGE, &portp->istate);
-			schedule_task(&portp->tqueue); 
+			schedule_work(&portp->tqueue); 
 			portp->stats.modem++;
 		}
 		break;

===============================
diffstat output:
stallion.c | 6 +++---

1 files changed, 3 insertions(+), 3 deletions(-)

===============================
Compiliation errors removed:
drivers/char/stallion.c: In function `stl_cd1400mdmisr':
drivers/char/stallion.c:4237: warning: implicit declaration of function `schedule_task'
================================
Linking errors removed:
drivers/built-in.o(.text+0x400ae): In function `stl_cd1400mdmisr':
: undefined reference to schedule_task' drivers/built-in.o(.text+0x41218): In function stl_sc26198txisr':
: undefined reference to schedule_task' drivers/built-in.o(.text+0x41699): In function stl_sc26198otherisr':
: undefined reference to `schedule_task'
make: *** [.tmp_vmlinux1] Error 1
=================================