Skip to contentSkip to conversation

2.4: add check_gcc for P3/P4

PATCH In review J.A. Magallon 2 participants 3 messages Aug 26, 2003

lore
Share & tools
lore

J.A. Magallon

author
#0 lore raw

PATCH 1/1 2.4: add check_gcc for P3/P4

Hi.

Resending for 2.4.23-pre ;)

--- linux-2.4.21-bp1/arch/i386/Makefile.orig 2003-06-18
23:40:25.000000000 +0200
+++ linux-2.4.21-bp1/arch/i386/Makefile 2003-06-18 23:59:25.000000000
+0200
@@ -53,11 +53,11 @@
endif

ifdef CONFIG_MPENTIUMIII
-CFLAGS += -march=i686
+CFLAGS += $(call check_gcc,-march=pentium3,-march=i686)
endif
Marcelo Tosatti <[email protected]> ifdef CONFIG_MPENTIUM4
-CFLAGS += -march=i686
+CFLAGS += $(call check_gcc,-march=pentium4,-march=i686)
endif

ifdef CONFIG_MK6

Signature · 4 lines
J.A. Magallon <[email protected]>      \                 Software is like sex:
werewolf.able.es                         \           It's better when it's free
Mandrake Linux release 9.2 (Cooker) for i586
Linux 2.4.22-jam1m (gcc 3.3.1 (Mandrake Linux 9.2 3.3.1-1mdk))
#1 lore raw
Quoted 9 lines · J.A. Magallon

Hi.

Resending for 2.4.23-pre ;)

--- linux-2.4.21-bp1/arch/i386/Makefile.orig 2003-06-18
23:40:25.000000000 +0200
+++ linux-2.4.21-bp1/arch/i386/Makefile 2003-06-18 23:59:25.000000000
+0200

Review line 58

Quoted 7 lines
(quoted diff) +1 -1
@@ -53,11 +53,11 @@
 endif
 
 ifdef CONFIG_MPENTIUMIII
-CFLAGS += -march=i686
+CFLAGS += $(call check_gcc,-march=pentium3,-march=i686)
 endif
 Marcelo Tosatti <[email protected]>

This is a rather strange make statement

Review line 63

Quoted 6 lines
(quoted diff) +1 -1
 ifdef CONFIG_MPENTIUM4
-CFLAGS += -march=i686
+CFLAGS += $(call check_gcc,-march=pentium4,-march=i686)
 endif
 
 ifdef CONFIG_MK6

--
vda

author
#2 lore raw
Quoted 8 lines · insecure
Quoted 7 lines · J.A. Magallon

Hi.

Resending for 2.4.23-pre ;)

--- linux-2.4.21-bp1/arch/i386/Makefile.orig 2003-06-18
23:40:25.000000000 +0200
+++ linux-2.4.21-bp1/arch/i386/Makefile 2003-06-18

23:59:25.000000000

Quoted 4 lines
Quoted 4 lines

+0200

(quoted diff) +0 -0
@@ -53,11 +53,11 @@
 endif
Quoted 8 lines

Review line 58

Quoted 5 lines
(quoted diff) +1 -1
 ifdef CONFIG_MPENTIUMIII
-CFLAGS += -march=i686
+CFLAGS += $(call check_gcc,-march=pentium3,-march=i686)
 endif
 Marcelo Tosatti <[email protected]>

This is a rather strange make statement

Oops, silly cut'n'paste in balsa...
Here is the good one:

--- linux-2.4.21-bp1/arch/i386/Makefile.orig 2003-06-18
23:40:25.000000000 +0200
+++ linux-2.4.21-bp1/arch/i386/Makefile 2003-06-18 23:59:25.000000000
+0200
@@ -53,11 +53,11 @@
endif

ifdef CONFIG_MPENTIUMIII
-CFLAGS += -march=i686
+CFLAGS += $(call check_gcc,-march=pentium3,-march=i686)
endif

ifdef CONFIG_MPENTIUM4
-CFLAGS += -march=i686
+CFLAGS += $(call check_gcc,-march=pentium4,-march=i686)
endif

ifdef CONFIG_MK6

Signature · 4 lines
J.A. Magallon <[email protected]>      \                 Software is like sex:
werewolf.able.es                         \           It's better when it's free
Mandrake Linux release 9.2 (Cooker) for i586
Linux 2.4.22-jam1m (gcc 3.3.1 (Mandrake Linux 9.2 3.3.1-1mdk))