New driver-id for radeon-i2c

Quoted 6 lines

Hi Greg,
I forgot to cc you when I sent the radeonfb-i2c patch to fbdev. I need a new driver-id:

Review line 102

Quoted 7 lines

--- linux-2.6.vanilla/include/linux/i2c-id.h Tue Jul 15 14:27:55
2003+++ linux-2.6/include/linux/i2c-id.h Wed Aug 20 19:22:58 2003

(quoted diff) +1 -0

@@ -99,6 +99,7 @@
 #define I2C_DRIVERID_24LC32A	51	/* Microchip 24LC32A 32k EEPROM	*/
 #define I2C_DRIVERID_STM41T00	52	/* real time clock		*/
 #define I2C_DRIVERID_UDA1342	53	/* UDA1342 audio codec		*/
+#define I2C_DRIVERID_RADEON	54	/* I2C bus on Radeon boards	*/

You need to coordinate this with the developers on the sensors mailing list. I've cc:ed the message there to get their approval (or suggestion for a different number.

Quoted 6 lines · Kronos

Quoted 5 lines

Hi Greg,
I forgot to cc you when I sent the radeonfb-i2c patch to fbdev. I need a new driver-id:

Quoted 10 lines

Review line 102

Quoted 7 lines

--- linux-2.6.vanilla/include/linux/i2c-id.h Tue Jul 15 14:27:55
2003+++ linux-2.6/include/linux/i2c-id.h Wed Aug 20 19:22:58 2003

(quoted diff) +1 -0

@@ -99,6 +99,7 @@
 #define I2C_DRIVERID_24LC32A	51	/* Microchip 24LC32A 32k EEPROM	*/
 #define I2C_DRIVERID_STM41T00	52	/* real time clock		*/
 #define I2C_DRIVERID_UDA1342	53	/* UDA1342 audio codec		*/
+#define I2C_DRIVERID_RADEON	54	/* I2C bus on Radeon boards	*/

Thanks, I've given you the id of 55, as someone else is already using
54. I'll send the patch on to Linus in a few days.

Hey, wait a minute. *We* (the LM Sensors group) are the authority for giving the IDs. And we gave 54 for Radeon. Whoever else is using 54 has no right to do so. So, please use 54 for Radeon in 2.6 too, and ask the other person to contact us to get an ID (which will probably be 55).

Quoted 5 lines

Hi Greg,
I forgot to cc you when I sent the radeonfb-i2c patch to fbdev. I need a new driver-id:

Review line 102

Quoted 7 lines

--- linux-2.6.vanilla/include/linux/i2c-id.h Tue Jul 15 14:27:55
2003+++ linux-2.6/include/linux/i2c-id.h Wed Aug 20 19:22:58 2003

(quoted diff) +1 -0

@@ -99,6 +99,7 @@
 #define I2C_DRIVERID_24LC32A	51	/* Microchip 24LC32A 32k EEPROM	*/
 #define I2C_DRIVERID_STM41T00	52	/* real time clock		*/
 #define I2C_DRIVERID_UDA1342	53	/* UDA1342 audio codec		*/
+#define I2C_DRIVERID_RADEON	54	/* I2C bus on Radeon boards	*/

Thanks, I've given you the id of 55, as someone else is already using
54. I'll send the patch on to Linus in a few days.

agreed.
Khali?

Quoted 45 lines · Greg KH

Quoted 7 lines · Jean Delvare

Quoted 7 lines · Kronos

Quoted 6 lines

Hi Greg,
I forgot to cc you when I sent the radeonfb-i2c patch to fbdev. I need a new driver-id:

Quoted 9 lines

Quoted 9 lines

Review line 102

Quoted 7 lines

--- linux-2.6.vanilla/include/linux/i2c-id.h Tue Jul 15 14:27:55
2003+++ linux-2.6/include/linux/i2c-id.h Wed Aug 20 19:22:58 2003

(quoted diff) +1 -0

@@ -99,6 +99,7 @@
 #define I2C_DRIVERID_24LC32A	51	/* Microchip 24LC32A 32k EEPROM	*/
 #define I2C_DRIVERID_STM41T00	52	/* real time clock		*/
 #define I2C_DRIVERID_UDA1342	53	/* UDA1342 audio codec		*/
+#define I2C_DRIVERID_RADEON	54	/* I2C bus on Radeon boards	*/

Thanks, I've given you the id of 55, as someone else is already

using>>54. I'll send the patch on to Linus in a few days.

Quoted 2 lines

Hey, wait a minute. *We* (the LM Sensors group) are the authority

for>giving the IDs. And we gave 54 for Radeon. Whoever else is using 54 has>no right to do so. So, please use 54 for Radeon in 2.6 too, and ask the>other person to contact us to get an ID (which will probably be 55).

Ah, the joys of trying to control a codebase that is out of your control :)

It looks like the big zoran driver update that went into the 2.6 kernel tree added an id for number 54:

	#define I2C_DRIVERID_ADV7170	54	/* video encoder	*/

As that driver also has 3 other ids, I guess they got there first.

I've cced the person who sent in the patch to Linus for this driver.

Personally, I think we should just make the Radeon #55 as I've done in the 2.6 tree and move on, we all have better things to do with our time...

thanks,

greg k-h

Quoted 18 lines · Jean Delvare

Quoted 7 lines · Kronos

Quoted 6 lines

Hi Greg,
I forgot to cc you when I sent the radeonfb-i2c patch to fbdev. I need a new driver-id:

Quoted 10 lines

Review line 102

Quoted 7 lines

--- linux-2.6.vanilla/include/linux/i2c-id.h Tue Jul 15 14:27:55
2003+++ linux-2.6/include/linux/i2c-id.h Wed Aug 20 19:22:58 2003

(quoted diff) +1 -0

@@ -99,6 +99,7 @@
 #define I2C_DRIVERID_24LC32A	51	/* Microchip 24LC32A 32k EEPROM	*/
 #define I2C_DRIVERID_STM41T00	52	/* real time clock		*/
 #define I2C_DRIVERID_UDA1342	53	/* UDA1342 audio codec		*/
+#define I2C_DRIVERID_RADEON	54	/* I2C bus on Radeon boards	*/

Thanks, I've given you the id of 55, as someone else is already using
54. I'll send the patch on to Linus in a few days.

Quoted 4 lines

Hey, wait a minute. *We* (the LM Sensors group) are the authority for giving the IDs. And we gave 54 for Radeon. Whoever else is using 54 has no right to do so. So, please use 54 for Radeon in 2.6 too, and ask the other person to contact us to get an ID (which will probably be 55).

Ah, the joys of trying to control a codebase that is out of your control :)

It looks like the big zoran driver update that went into the 2.6 kernel tree added an id for number 54:

	#define I2C_DRIVERID_ADV7170	54	/* video encoder	*/

As that driver also has 3 other ids, I guess they got there first.

I've cced the person who sent in the patch to Linus for this driver.

Personally, I think we should just make the Radeon #55 as I've done in the 2.6 tree and move on, we all have better things to do with our time...

thanks,

greg k-h