(Simple) Basic Design Flaw in make menuconfig GUI
Hello, and thanks to all for continued support and developement of the Linux kernel. :)
APPLICATION: This applies to all kernels, all distributions, and all architectures...
DESRIPTION: "make menuconfig" GUI issue
SETUP: When I run "make menuconfig" and I am in the process of enabling/disabling options, I have a "bad habit?" (that I'm sure is more like an epidemic) of placing one finger on the "Esc" key, one finger on the "Space" key, and another on the "Enter" key as I manuver through the various selections.
PROBLEM: (ocassionally) While I am speeding through the kernel configuration, I will accidentally hit the "Esc" key one too many times (I'm sure we've all done this) and it will leave me at the "exit" screen:
Do you wish to save your new kernel config?
<Yes> <No>
In this case, neither choice is acceptable. In a plea to save time for all, can someone please add one more simple choice to the "exit" menu?
Do you wish to save your new kernel config?
<Yes> <No> <Return to Config>
Thanks for your time, and thanks once again for all who continually work towards the advancement of Linux.
Regards,
Steve Hampton
On Wed, 3 Sep 2003 10:40:17 -0400 "Stevo" <[email protected]> wrote:
| PROBLEM: (ocassionally) While I am speeding through the kernel | configuration, I will accidentally hit the "Esc" key one too many times (I'm | sure we've all done this) and it will leave me at the "exit" screen: | | Do you wish to save your new kernel config? | | <Yes> <No> | | In this case, neither choice is acceptable. In a plea to save time for all, | can someone please add one more simple choice to the "exit" menu? | | Do you wish to save your new kernel config? | | <Yes> <No> <Return to Config>
Yes, I've needed that choice at times also.
--
~Randy
On Wed, 2003-09-03 08:33:34 -0700, Randy.Dunlap <[email protected]> wrote in message <[email protected]>:
Quoted 9 lines · On Wed, 3 Sep 2003 10:40:17 -0400 "Stevo" <[email protected]> wrote:
| PROBLEM: (ocassionally) While I am speeding through the kernel | configuration, I will accidentally hit the "Esc" key one too many times (I'm | sure we've all done this) and it will leave me at the "exit" screen:| can someone please add one more simple choice to the "exit" menu?
Yes, I've needed that choice at times also.
Like this?
scripts/kconfig/mconf.c renamed from scripts/kconfig/mconf.c.jbglaw +49 -20
@@ -773,27 +773,56 @@tcgetattr (1 , &ios_org);atexit (conf_cleanup);init_wsize (); -conf (&rootmenu); -do { -cprint_init (); -cprint ("--yesno" ); -cprint ("Do you wish to save your new kernel configuration?" ); -cprint ("5" ); -cprint ("60" ); - stat =exec_conf (); - }while (stat <0 ); - -if (stat ==0 ) { -conf_write (NULL ); -printf ("\n\n" -"*** End of Linux kernel configuration.\n" -"*** Execute 'make' to build the kernel or try 'make help'." -"\n\n" ); - }else -printf ("\n\n" -"Your kernel configuration changes were NOT saved." -"\n\n" ); +while (1 ) { +/* +* Config dialog +*/ +conf (&rootmenu); + +/* +* Really quit? +*/ +do { +cprint_init (); +cprint ("--title" ); +cprint ("Save configuration" ); +cprint ("--radiolist" ); +cprint (radiolist_instructions); +cprint ("15" ); +cprint ("70" ); +cprint ("6" ); + +cprint ("continue" ); +cprint ("Continue with configuation" ); +cprint ("ON" ); + +cprint ("save" ); +cprint ("Save .config and exit" ); +cprint ("OFF" ); + +cprint ("exit" ); +cprint ("Don't save .config and exit" ); +cprint ("OFF" ); + + stat =exec_conf (); + }while (stat <0 ); + +if (!strcmp (input_buf,"save" )) { +conf_write (NULL ); +printf ("\n\n" +"*** End of Linux kernel configuration.\n" +"*** Execute 'make' to build the kernel or try 'make help'." +"\n\n" ); +return 0 ; + } +if (!strcmp (input_buf,"exit" )) { +printf ("\n\n" +"Your kernel configuration changes were NOT saved." +"\n\n" ); +return 0 ; + } + }return 0 ; }
MfG, JBG
Signature · 4 lines
Jan-Benedict Glaw [email protected] . +49-172-7608481 "Eine Freie Meinung in einem Freien Kopf | Gegen Zensur | Gegen Krieg fuer einen Freien Staat voll Freier Bürger" | im Internet! | im Irak! ret = do_actions((curr | FREE_SPEECH) & ~(IRAQ_WAR_2 | DRM | TCPA));
On Wed, 3 Sep 2003 19:03:48 +0200 Jan-Benedict Glaw <[email protected]> wrote:
| On Wed, 2003-09-03 08:33:34 -0700, Randy.Dunlap <[email protected]> | wrote in message <[email protected]>: | > On Wed, 3 Sep 2003 10:40:17 -0400 "Stevo" <[email protected]> wrote: | > | > | PROBLEM: (ocassionally) While I am speeding through the kernel | > | configuration, I will accidentally hit the "Esc" key one too many times (I'm | > | sure we've all done this) and it will leave me at the "exit" screen: | | > | can someone please add one more simple choice to the "exit" menu? | > | > Yes, I've needed that choice at times also. | | Like this? | | | --- linux-2.6.0-test4-bk5/scripts/kconfig/mconf.c.jbglaw 2003-09-03 18:28:06.000000000 +0200 | +++ linux-2.6.0-test4-bk5/scripts/kconfig/mconf.c 2003-09-03 19:00:31.000000000 +0200 | @@ -773,27 +773,56 @@ | tcgetattr(1, &ios_org); | atexit(conf_cleanup); | init_wsize(); | - conf(&rootmenu); | | - do { | - cprint_init(); | - cprint("--yesno"); | - cprint("Do you wish to save your new kernel configuration?"); | - cprint("5"); | - cprint("60"); | - stat = exec_conf(); | - } while (stat < 0); | - | - if (stat == 0) { | - conf_write(NULL); | - printf("\n\n" | - "*** End of Linux kernel configuration.\n" | - "*** Execute 'make' to build the kernel or try 'make help'." | - "\n\n"); | - } else | - printf("\n\n" | - "Your kernel configuration changes were NOT saved." | - "\n\n"); | + while (1) { | + /* | + * Config dialog | + */ | + conf(&rootmenu); | + | + /* | + * Really quit? | + */ | + do { | + cprint_init(); | + cprint("--title"); | + cprint("Save configuration"); | + cprint("--radiolist"); | + cprint(radiolist_instructions); | + cprint("15"); | + cprint("70"); | + cprint("6"); | + | + cprint("continue"); | + cprint("Continue with configuation"); | + cprint("ON"); | + | + cprint("save"); | + cprint("Save .config and exit"); | + cprint("OFF"); | + | + cprint("exit"); | + cprint("Don't save .config and exit"); | + cprint("OFF"); | + | + stat = exec_conf(); | + } while (stat < 0); | + | + if(!strcmp(input_buf, "save")) { | + conf_write(NULL); | + printf("\n\n" | + "*** End of Linux kernel configuration.\n" | + "*** Execute 'make' to build the kernel or try 'make help'." | + "\n\n"); | + return 0; | + } | + if(!strcmp(input_buf, "exit")) { | + printf("\n\n" | + "Your kernel configuration changes were NOT saved." | + "\n\n"); | + return 0; | + } | + } | | return 0; | }
Yes, that works nicely. Merge and ship it!
--
~Randy
"Stevo" <[email protected]> said on Wed, 3 Sep 2003 10:40:17 -0400:
Quoted 6 lines
PROBLEM: (ocassionally) While I am speeding through the kernel configuration, I will accidentally hit the "Esc" key one too many times (I'm sure we've all done this) and it will leave me at the "exit" screen:
Do you wish to save your new kernel config?
Quoted 8 lines
<Yes> <No>
In this case, neither choice is acceptable. In a plea to save time for all, can someone please add one more simple choice to the "exit" menu?
Do you wish to save your new kernel config?
<Yes> <No> <Return to Config>
Similarly, I often ctrl-z the configure step, and when fging the process again, things end up a bit strange - IIRC, it goes to the next menu level up from the current one, and sometimes ends up with strange keystrokes? It's been a while since I have tried, so I can't quite recall the details, sorry.
Probably not quite so easy to fix as the solution to this one, unfortuneately :(
Signature · 2 lines
TimC -- http://astronomy.swin.edu.au/staff/tconnors/ Black holes are where God divided by zero. -- Steven Wright