Skip to contentSkip to conversation

[PATCH] [[email protected]: Re: ipt_physdev.c alignment problems on parisc64]

PATCH In review Arnaldo Carvalho de Melo 2 participants 2 messages Sep 3, 2003 – Sep 4, 2003

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 [PATCH] [[email protected]: Re: ipt_physdev.c alignment problems on parisc64]

Bart,

Yes, it makes ipt_pysdev.c compile on parisc, Dave, could you please
apply it? Or perhaps wait for the netfilter patches, your call.

- Arnaldo

----- Forwarded message from Bart De Schuymer <[email protected]> -----

Date: Tue, 2 Sep 2003 21:16:41 +0200
From: Bart De Schuymer <[email protected]>
Subject: Re: ipt_physdev.c alignment problems on parisc64
To: Arnaldo Carvalho de Melo <[email protected]>,
[email protected]
Cc: Linux Networking Development Mailing List <[email protected]>

Quoted 1 line · Arnaldo Carvalho de Melo

The 1.786.1.54 changeset (i.e. the initial ipt_physdev.c one 8) created

Does this fix it?

cheers,
Bart

include/linux/netfilter_ipv4/ipt_physdev.h renamed from include/linux/netfilter_ipv4/ipt_physdev.h.old +1 -1
@@ -15,7 +15,7 @@
 struct ipt_physdev_info {
 	u_int8_t invert;
 	u_int8_t bitmask;
-	char physindev[IFNAMSIZ];
+	char physindev[IFNAMSIZ] __attribute__ ((aligned (__alignof__(unsigned long))));
 	char in_mask[IFNAMSIZ];
 	char physoutdev[IFNAMSIZ];
 	char out_mask[IFNAMSIZ];

----- End forwarded message -----

#1 lore raw
Quoted 2 lines · On Wed, 3 Sep 2003 13:20:23 -0300 Arnaldo Carvalho de Melo…

Yes, it makes ipt_pysdev.c compile on parisc, Dave, could you please
apply it? Or perhaps wait for the netfilter patches, your call.

As I mentioned in another email, this patch can't be used, it breaks in mixed 32/64 bit environments.