Skip to contentSkip to conversation

BUG: 2.4.23-pre3 + ifconfig

DISCUSSION Abraham van der Merwe 3 participants 8 messages Sep 4, 2003 – Sep 9, 2003 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi!

I just installed 2.4.23-pre3 on one of our servers. If I up/down the loopback device multiple times ifconfig hangs on the second down (as in unkillable) and afterwards ifconfig stops functioning and I can't reboot the machine, etc.

No oopses, kernel panics, messages or anything. The system is still alive, it is just as if some system call is hung.

If anyone is interested, I can send my .config or any other relevant details.

Signature · 11 lines
Regards
 Abraham

"Consequences, Schmonsequences, as long as I'm rich."
		-- "Ali Baba Bunny" [1957, Chuck Jones]

___________________________________________________
 Abraham vd Merwe - Frogfoot Networks CC
 9 Kinnaird Court, 33 Main Street, Newlands, 7700
 Phone: +27 21 686 1665 Cell: +27 82 565 4451
 Http: http://www.frogfoot.net/ Email: [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

Hi Fedor >@2003.09.07_21:17:02_+0200

Quoted 5 lines
Quoted 5 lines

I just installed 2.4.23-pre3 on one of our servers. If I up/down the loopback device multiple times ifconfig hangs on the second down (as in unkillable) and afterwards ifconfig stops functioning and I can't reboot the machine, etc.

Quoted 7 lines
Quoted 5 lines

No oopses, kernel panics, messages or anything. The system is still alive, it is just as if some system call is hung.

If anyone is interested, I can send my .config or any other relevant details.

I have the same problem. Did you find any solution?

No :P Not even sure if anyone on lkml noticed my bug report.

Signature · 11 lines
Regards
 Abraham

Carmel, New York, has an ordinance forbidding men to wear coats and
trousers that don't match.

___________________________________________________
 Abraham vd Merwe - Frogfoot Networks CC
 9 Kinnaird Court, 33 Main Street, Newlands, 7700
 Phone: +27 21 686 1665 Cell: +27 82 565 4451
 Http: http://www.frogfoot.net/ Email: [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw

Re: possibly bug in 8139cp? (WAS Re: BUG: 2.4.23-pre3 + ifconfig)

Hi Fedor >@2003.09.08_18:43:25_+0200

Not sure if you've stumbled onto the same bug as me.

My server have 2 Netgear cards and I'm using the National Semiconductor dp8381x driver included with 2.4.23-pre3.

Also, my system doesn't lock up after `ifconfig lo down', ifconfig just hangs and becomes unkillable and I can't reboot the machine, use ifconfig anymore, etc.

Quoted 29 lines

Actually for me this happens when I do "pump -i eth0"
The system is frozen dead (even SysRq-B does not work) That's when I am using 8139cp driver (no problem in 2.4.22) I tried using 8139too (I believe it is supposed to work, right?) - I do not get this lockup, but instead it starts printing "too much work at interrupt " messages all the time. It could be connected to the latest changes in 8139 drivers...

Fedor

Quoted 17 lines · Abraham van der Merwe

Hi Fedor

Quoted 7 lines

@2003.09.07_21:17:02_+0200

Quoted 5 lines

I just installed 2.4.23-pre3 on one of our servers. If I up/down the loopback device multiple times ifconfig hangs on the second down (as in unkillable) and afterwards ifconfig stops functioning and I can't reboot the machine, etc.

Quoted 7 lines
Quoted 5 lines

No oopses, kernel panics, messages or anything. The system is still alive, it is just as if some system call is hung.

If anyone is interested, I can send my .config or any other relevant details.

I have the same problem. Did you find any solution?

No :P Not even sure if anyone on lkml noticed my bug report.

Signature · 11 lines
Regards
 Abraham

Moderation in all things.
		-- Publius Terentius Afer [Terence]

___________________________________________________
 Abraham vd Merwe - Frogfoot Networks CC
 9 Kinnaird Court, 33 Main Street, Newlands, 7700
 Phone: +27 21 686 1665 Cell: +27 82 565 4451
 Http: http://www.frogfoot.net/ Email: [email protected]
#5 lore raw

Re: possibly bug in 8139cp? (WAS Re: BUG: 2.4.23-pre3 + ifconfig)

In reply to a message not in the archive
Quoted 4 lines · Fedor Karpelevitch
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

I just installed 2.4.23-pre3 on one of our servers. If I up/down the loopback device multiple times ifconfig hangs on the second down (as in unkillable) and afterwards ifconfig stops functioning and I can't reboot the machine, etc.

This sounds like the NAPI bug we're chasing.

Jeff

#6 lore raw

Re: possibly bug in 8139cp? (WAS Re: BUG: 2.4.23-pre3 + ifconfig)

Quoted 9 lines · Jeff Garzik
Quoted 4 lines · Fedor Karpelevitch
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

I just installed 2.4.23-pre3 on one of our servers. If I up/down the loopback device multiple times ifconfig hangs on the second down (as in unkillable) and afterwards ifconfig stops functioning and I can't reboot the machine, etc.

This sounds like the NAPI bug we're chasing.

Well it's the same as the bug which was recently added to 2.6:

- dev_close() used to do

	test_bit(__LINK_STATE_RX_SCHED, &dev->state);

- the netif_poll_disable() in tg3.c used to do

	test_and_set_bit(__LINK_STATE_RX_SCHED, &dev->state);

- someone copied the tg3 netif_poll_disable() into netdevice.h and then used it in dev_close(), thus changing and presumably breaking dev_close().

I haven't tested this yet, but it'll probably fix things for all NICs and it might break tg3. In which case it's a net win ;)

include/linux/netdevice.h renamed from include/linux/netdevice.h~ifdown-lockup-fix +1 -1
diff -puN include/linux/netdevice.h~ifdown-lockup-fix include/linux/netdevice.h
@@ -854,7 +854,7 @@ static inline void netif_rx_complete(str
 
 static inline void netif_poll_disable(struct net_device *dev)
 {
-	while (test_and_set_bit(__LINK_STATE_RX_SCHED, &dev->state)) {
+	while (test_bit(__LINK_STATE_RX_SCHED, &dev->state)) {
 		/* No hurry. */
 		current->state = TASK_INTERRUPTIBLE;
 		schedule_timeout(1);

_

#7 lore raw

Re: possibly bug in 8139cp? (WAS Re: BUG: 2.4.23-pre3 + ifconfig)

include/linux/netdevice.h static inline void netif_rx_complete(str · line 860

Quoted 13 lines · Andrew Morton

diff -puN include/linux/netdevice.h~ifdown-lockup-fix include/linux/netdevice.h

include/linux/netdevice.h renamed from include/linux/netdevice.h~ifdown-lockup-fix +1 -1
@@ -854,7 +854,7 @@ static inline void netif_rx_complete(str
 
 static inline void netif_poll_disable(struct net_device *dev)
 {
-	while (test_and_set_bit(__LINK_STATE_RX_SCHED, &dev->state)) {
+	while (test_bit(__LINK_STATE_RX_SCHED, &dev->state)) {
 		/* No hurry. */
 		current->state = TASK_INTERRUPTIBLE;
 		schedule_timeout(1);

no that breaks other things.

Jeff

#8 lore raw

Re: possibly bug in 8139cp? (WAS Re: BUG: 2.4.23-pre3 + ifconfig)

Quoted 7 lines · Jeff Garzik
Quoted 5 lines · Andrew Morton

diff -puN include/linux/netdevice.h~ifdown-lockup-fix include/linux/netdevice.h

include/linux/netdevice.h renamed from include/linux/netdevice.h~ifdown-lockup-fix +0 -0
@@ -854,7 +854,7 @@ static inline void netif_rx_complete(str
 
Quoted 12 lines

include/linux/netdevice.h static inline void netif_rx_complete(str · line 860

Quoted 8 lines
include/linux/netdevice.h renamed from include/linux/netdevice.h~ifdown-lockup-fix +1 -1
 static inline void netif_poll_disable(struct net_device *dev)
 {
-	while (test_and_set_bit(__LINK_STATE_RX_SCHED, &dev->state)) {
+	while (test_bit(__LINK_STATE_RX_SCHED, &dev->state)) {
 		/* No hurry. */
 		current->state = TASK_INTERRUPTIBLE;
 		schedule_timeout(1);

no that breaks other things.

The only thing it can break is tg3, which appears to be placing a competing interpretation upon the handling of this flag.

Given that tg3_netif_stop() will set __LINK_STATE_RX_SCHED and dev_close() will then loop on it getting cleared again there appears to be a risk that a dev_close() against tg3 will lock up.

It's all very unclear. And uncommented, but that is experientially the same thing :(

#9 lore raw

Re: possibly bug in 8139cp? (WAS Re: BUG: 2.4.23-pre3 + ifconfig)

Quoted 2 lines · Andrew Morton

The only thing it can break is tg3, which appears to be placing a competing interpretation upon the handling of this flag.

Right, so, don't break tg3 :) The patch I posted doesn't do the _and_set, which tg3 needs. netif_poll_{enable,disable} control whether the net stack may call the dev->poll() function. tg3 asynchronously disables polling, resets the phy and/or hardware, then enables polling again.

I thought I had a check in there for when it was contending with dev_close(), but I'll look again. The hardware/phy reset should continue to occur regardless of dev_close() -- that's ok. During this event, all rx/tx is already stopped anyway. So we can let ifdown/ifup events occur in parallel... carefully. :)

Ideally we want to present a machine that's asynchronously managing its power state and various functions. dev->open() and dev->close() events become just two more "major events."

Jeff