make checkconfig problem
You probably already know this...
Someone mentioned to me that 'make checkconfig' isn't working. However, 'make checkincludes' does work.
'checkconfig' contains the string 'config', which implies to Makefile that this is a configs-target...
Using a target named 'checkconf' works. Patch is below.
Or fix it however you like, of course.
--
~Randy
patch_name: check_targets.patchpatch_version: 2003-09-04.12:31:41
author: Randy.Dunlap <[email protected]>
description: make checkconf so that it won't be a configs-target
product: Linuxproduct_versions: 2.6.0-test4
Makefile renamed from Makefile~targets +1 -1
@@ -815,7 +815,7 @@ # Scripts to check various things for consistency # --------------------------------------------------------------------------- -checkconfig: +checkconf: find * $(RCS_FIND_IGNORE) \ -name '*.[hcS]' -type f -print | sort \ | xargs $(PERL) -w scripts/checkconfig.pl
Quoted 5 lines · Randy.Dunlap
You probably already know this...
Someone mentioned to me that 'make checkconfig' isn't working. However, 'make checkincludes' does work.
It had crossed my mind, and my plan was actually to get rid of them since the scripts were not updated. Good to see you are looking into this now.
If we want to keep them in the kernel, I suggest a new naming:
configcheck:
includecheck:
This follows the *config pattern, but suffixed with check.
A tangent - could it be possible to build this into sparse instead? The plan is to give it more kernel awareness anyway, so it should be simple to check for the above as well.
Sam
Quoted 9 lines · Randy.Dunlap
Quoted 5 lines
You probably already know this...
Someone mentioned to me that 'make checkconfig' isn't working. However, 'make checkincludes' does work.
It had crossed my mind, and my plan was actually to get rid of them since the scripts were not updated. Good to see you are looking into this now.
They work now, and I'd like to add 'checkversion.pl' as well.
Quoted 5 lines
If we want to keep them in the kernel, I suggest a new naming:
configcheck:
includecheck:This follows the *config pattern, but suffixed with check.
OK, I don't mind how they are spelled.
Quoted 3 lines
A tangent - could it be possible to build this into sparse instead? The plan is to give it more kernel awareness anyway, so it should
be simple to check for the above as well.
I don't know, but I'll discuss it with Dave Olien.
Thanks,
~Randy