Skip to contentSkip to conversation

ATM - fix seqfile compile failure

PATCH In review John Levon 2 participants 2 messages Sep 5, 2003

Subsystems (3)
Networking Network drivers ATM
lore
Share & tools
lore

John Levon

author
#0 lore raw

PATCH 1/1 ATM - fix seqfile compile failure

The recent conversion to seq_file breaks CONFIG_ATM_BR2684_IPFILTER compile.

I have absolutely no idea what the original author was attempting to achieve with the "pos" thing, btw ... *shrug*

Entirely untested.

regards
john

net/atm/br2684.c +2 -2
diff -Naurp -X dontdiff linux-cvs/net/atm/br2684.c linux-fixes/net/atm/br2684.c
@@ -732,8 +732,8 @@ static int br2684_seq_show(struct seq_fi
 #ifdef CONFIG_ATM_BR2684_IPFILTER
 #define b1(var, byte)	((u8 *) &brvcc->filter.var)[byte]
 #define bs(var)		b1(var, 0), b1(var, 1), b1(var, 2), b1(var, 3)
-			if (brvcc->filter.netmask != 0 && pos-- == 0)
-				return sprintf(buf, "    filter=%d.%d.%d.%d/"
+			if (brvcc->filter.netmask != 0)
+				seq_printf(seq, "    filter=%d.%d.%d.%d/"
 				    "%d.%d.%d.%d\n", bs(prefix), bs(netmask));
 #undef bs
 #undef b1
#1 lore raw
Quoted 2 lines

The recent conversion to seq_file breaks CONFIG_ATM_BR2684_IPFILTER compile.

i sent in a patch for this already. i did a bit of testing.

Quoted 2 lines

I have absolutely no idea what the original author was attempting to achieve with the "pos" thing, btw ... *shrug*

the "pos" stuff was used by the old proc interface.