Skip to contentSkip to conversation

IDE: Fix Power Management request race on resume

PATCH [email protected] 2 participants 4 messages Sep 10, 2003

lore
Share & tools
lore
#2 lore raw
Quoted 9 lines · Benjamin Herrenschmidt
Quoted 3 lines · On Wed, 2003-09-10 at 11:04, [email protected] wrote:

I applied this patch to 2.6.0-test5 and still have this problem:

http://marc.theaimsgroup.com/?l=linux-kernel&m=106218353005043&w=2

There are a couple of other fixes pending though I don't thing they are related to your problem. Do you have a slave drive on this channel ? What driver are you using for the host controller ? Does it have a dma_check() function ?

It's a laptop, so there's no slave drive.

The host controller is a PIIX4, using CONFIG_BLK_DEV_PIIX. (Presumably drivers/ide/pci/piix.c)

$ grep dma_check piix.c 
        hwif->ide_dma_check = &piix_config_drive_xfer_rate;

Charlie

#3 lore raw
Quoted 4 lines · On Wed, 2003-09-10 at 11:25, [email protected] wrote:
Quoted 3 lines · Benjamin Herrenschmidt
Quoted 2 lines · On Wed, 2003-09-10 at 11:04, [email protected] wrote:

I applied this patch to 2.6.0-test5 and still have this problem:

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

http://marc.theaimsgroup.com/?l=linux-kernel&m=106218353005043&w=2

There are a couple of other fixes pending though I don't thing they are related to your problem. Do you have a slave drive on this channel ? What driver are you using for the host controller ? Does it have a dma_check() function ?

It's a laptop, so there's no slave drive.

Some laptops have the CD/DVD as a slave

Quoted 6 lines

The host controller is a PIIX4, using CONFIG_BLK_DEV_PIIX. (Presumably drivers/ide/pci/piix.c)

$ grep dma_check piix.c 
        hwif->ide_dma_check = &piix_config_drive_xfer_rate;

Can you put some printk in there to verify it's properly called on wakeup and that it actually does something ?

Note that problem may be unrelated to the IDE driver, it could also be some APIC problem messing with interrupts...

Ben.