Skip to contentSkip to conversation

incorrect extern declarations

PATCH In review Olaf Hering 1 participant 2 messages Sep 14, 2003 – Oct 9, 2003

lore
Share & tools
lore

Olaf Hering

author
#0 lore raw

PATCH 1/1 incorrect extern declarations

both variables are declared static earlier in the file. gcc3.4 doesnt tolerated the extern anymore.

arch/ppc/platforms/prep_pci.c renamed from arch/ppc/platforms/prep_pci.c~ +0 -2
@@ -1141,8 +1141,6 @@ void __init
 prep_pcibios_fixup(void)
 {
         struct pci_dev *dev;
-        extern unsigned char *Motherboard_map;
-        extern unsigned char *Motherboard_routes;
 
 	prep_route_pci_interrupts();

--
USB is for mice, FireWire is for men!

sUse lINUX ag, nÜRNBERG

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

author
#1 lore raw
Quoted 7 lines · Olaf Hering

both variables are declared static earlier in the file. gcc3.4 doesnt tolerated the extern anymore.

arch/ppc/platforms/prep_pci.c void __init · line 1145

Quoted 7 lines
arch/ppc/platforms/prep_pci.c renamed from arch/ppc/platforms/prep_pci.c~ +0 -2
@@ -1141,8 +1141,6 @@ void __init
 prep_pcibios_fixup(void)
 {
         struct pci_dev *dev;
-        extern unsigned char *Motherboard_map;
-        extern unsigned char *Motherboard_routes;
 
 	prep_route_pci_interrupts();

This fixes another bug. __bss_start is declared twice.

arch/ppc/kernel/setup.c +2 -2
diff -p -purN linux-2.4.22/arch/ppc/kernel/setup.c linux-2.4.23-pre6-irda-gcc34/arch/ppc/kernel/setup.c
@@ -258,7 +258,7 @@ __init
 unsigned long
 early_init(int r3, int r4, int r5)
 {
-	extern char __bss_start, _end;
+	extern char __bss_start[], _end[];
  	unsigned long phys;
 	unsigned long offset = reloc_offset();
 

@@ -267,7 +267,7 @@ early_init(int r3, int r4, int r5)
 
 	/* First zero the BSS -- use memset, some arches don't have
 	 * caches on yet */
-	memset_io(PTRRELOC(&__bss_start), 0, &_end - &__bss_start);
+	memset_io(PTRRELOC(&__bss_start), 0, _end - __bss_start);
 
 	/*
 	 * Identify the CPU type and fix up code sections
arch/ppc/platforms/prep_pci.c +0 -2
diff -p -purN linux-2.4.22/arch/ppc/platforms/prep_pci.c linux-2.4.23-pre6-irda-gcc34/arch/ppc/platforms/prep_pci.c
@@ -1141,8 +1141,6 @@ void __init
 prep_pcibios_fixup(void)
 {
         struct pci_dev *dev;
-        extern unsigned char *Motherboard_map;
-        extern unsigned char *Motherboard_routes;
 
 	prep_route_pci_interrupts();

--
USB is for mice, FireWire is for men!

sUse lINUX ag, nÜRNBERG

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/