fix sbni.c compile with gcc 3.3
PATCH 1/1 fix sbni.c compile with gcc 3.3
sbni.c in 2.6.0-test5 fails to compile with gcc 3.3 with the following error:
<-- snip -->
...
CC drivers/net/wan/sbni.o
...drivers/net/wan/sbni.c: In function `calc_crc32':drivers/net/wan/sbni.c:1568: error: asm-specifier for variable `_crc' conflicts with asm clobber list
make[3]: *** [drivers/net/wan/sbni.o] Error 1
<-- snip -->
Below is the patch by Margit Schubert-White to fix this issue (it is already in 2.4).
cu
Adrian
drivers/net/wan/sbni.c +7 -7
@@ -1562,13 +1552,13 @@static u32 calc_crc32 (u32 crc,u8 *p,u32 len ) { - registeru32 _crc __asm ("ax" ); + registeru32 _crc; _crc = crc; __asm __volatile ("xorl %%ebx, %%ebx\n" -"movl %1, %%esi\n" -"movl %2, %%ecx\n" +"movl %2, %%esi\n" +"movl %3, %%ecx\n" "movl $crc32tab, %%edi\n" "shrl $2, %%ecx\n" "jz 1f\n"
@@ -1604,7 +1594,7 @@"jnz 0b\n" "1:\n" -"movl %2, %%ecx\n" +"movl %3, %%ecx\n" "andl $3, %%ecx\n" "jz 2f\n"
@@ -1629,9 +1619,9 @@ "xorb 2(%%esi), %%bl\n" "xorl (%%edi,%%ebx,4), %%eax\n" "2:\n" - : - : "a" (_crc), "g" (p), "g" (len) - : "ax", "bx", "cx", "dx", "si", "di" + : "=a" (_crc) + : "0" (_crc), "g" (p), "g" (len) + : "bx", "cx", "dx", "si", "di" );return _crc;
Jeff Garzik
Appliedapplied to 2.6