ALSA pci Kconfig polishes
PATCH 1/1 ALSA pci Kconfig polishes
Hi.
I think the ALSA pci devices must select the GAMEPORT option automatically instead of depends on GAMEPORT.
The GAMEPORT is a feature of the device, is not a requisite.
Signature · 3 lines
Ramón Rey Vicente <ramon dot rey at hispalinux dot es>
jabber ID <rreylinux at jabber dot org>
GPG public key ID 0xBEBD71D5 -> http://pgp.escomposlinux.org/pci/Kconfig +14 -7
@@ -17,7 +17,8 @@ config SND_CS46XX tristate "Cirrus Logic (Sound Fusion) CS4280/CS461x/CS462x/CS463x" - depends on SND && GAMEPORT + depends on SND + select GAMEPORT help Say 'Y' or 'M' to include support for Cirrus Logic CS4610 / CS4612 / CS4614 / CS4615 / CS4622 / CS4624 / CS4630 / CS4280 chips.
@@ -30,7 +31,8 @@ config SND_CS4281 tristate "Cirrus Logic (Sound Fusion) CS4281" - depends on SND && GAMEPORT + depends on SND + select GAMEPORT help Say 'Y' or 'M' to include support for Cirrus Logic CS4281.
@@ -83,7 +85,8 @@ config SND_TRIDENT tristate "Trident 4D-Wave DX/NX; SiS 7018" - depends on SND && GAMEPORT + depends on SND + select GAMEPORT help Say 'Y' or 'M' to include support for Trident 4D-Wave DX/NX and SiS 7018 soundcards.
@@ -110,20 +113,23 @@ config SND_ENS1370 tristate "(Creative) Ensoniq AudioPCI 1370" - depends on SND && GAMEPORT + depends on SND + select GAMEPORT help Say 'Y' or 'M' to include support for Ensoniq AudioPCI ES1370. config SND_ENS1371 tristate "(Creative) Ensoniq AudioPCI 1371/1373" - depends on SND && GAMEPORT + depends on SND + select GAMEPORT help Say 'Y' or 'M' to include support for Ensoniq AudioPCI ES1371 and Sound Blaster PCI 64 or 128 soundcards. config SND_ES1938 tristate "ESS ES1938/1946/1969 (Solo-1)" - depends on SND && GAMEPORT + depends on SND + select GAMEPORT help Say 'Y' or 'M' to include support for ESS Solo-1 (ES1938, ES1946, ES1969) soundcard.
@@ -173,7 +179,8 @@ config SND_SONICVIBES tristate "S3 SonicVibes" - depends on SND && GAMEPORT + depends on SND + select GAMEPORT help Say 'Y' or 'M' to include support for S3 SonicVibes based soundcards.
Quoted 6 lines · Ram?n Rey Vicente
Hi.
I think the ALSA pci devices must select the GAMEPORT option automatically instead of depends on GAMEPORT.
The GAMEPORT is a feature of the device, is not a requisite.
This patch makes GAMEPORT required, while actually it's only required to not be a module if the sound driver is builtin. See my earlier mail on the subject for the details:
http://marc.theaimsgroup.com/?l=linux-kernel&m=106479206731633&w=2
A better fix would be to revert the change in sound/pci/Kconfig from CONFIG_SOUND_GAMEPORT to CONFIG_GAMEPORT back to CONFIG_SOUND_GAMEPORT, or just drop this dependency for ALSA and let the #ifdefs in the code take care of it. Forcing the gameport to be compiled in when it's not necessary is bloat, IMHO.
Signature · 2 lines
Muli Ben-Yehuda http://www.mulix.org