Skip to contentSkip to conversation

NFS partial writes

DISCUSSION Kenny Simpson 1 participant 1 message Sep 29, 2003

lore
Share & tools
lore
#0 lore raw

Hi, in nfs_writepage_sync in fs/nfs/write.c I see:

result = NFS_PROTO(inode)->write(inode, cred,
&fattr, flags,
offset, wsize,
page, &verf);

  if (result < 0) {
          /* Must mark the page invalid after I/O
error */
          ClearPageUptodate(page);
          goto io_error;

}
if (result != wsize)
printk("NFS: short write, wsize=%u,
result=%d\n",

          wsize, result);
  refresh = 1;
  buffer  += wsize;
  base    += wsize;
  offset  += wsize;

written += wsize;
count -= wsize;

Shouldn't buffer, base, offset, written, and count be (inc|dec)remented by result instead of wsize?

This is with the latest CVS version of 2.5, but the identical code is in Red Hat's 2.4.20-20.9.

-Kenny

__________________________________
Do you Yahoo!?
The New Yahoo! Shopping - with improved product search
http://shopping.yahoo.com