Warnings in 8250_acpi

PATCH In review Dmitry Torokhov 3 participants 3 messages Oct 6, 2003

Share & tools

Dmitry Torokhov

author

2003-10-06 06:32 UTC #0 lore raw

PATCH 1/1 Warnings in 8250_acpi

Lastest changes in 8250_acpi.c produce warnings about type mismatch in printk. We could either change format to print long long arguments or, until most of us are on 64 bits, just trim values to 32.

Dmitry

drivers/serial/8250_acpi.c Mon Oct 6 01:18:22 2003 renamed from drivers/serial/8250_acpi.c Wed Oct 1 04:11:17 2003 +3 -2

@@ -28,8 +28,9 @@
        req->iomem_base = ioremap(req->iomap_base, size);
        if (!req->iomem_base) {
                printk(KERN_ERR "%s: couldn't ioremap 0x%lx-0x%lx\n",
-                       __FUNCTION__, addr->min_address_range,
-                       addr->max_address_range);
+                       __FUNCTION__,
+                       (unsigned long)addr->min_address_range,
+                       (unsigned long)addr->max_address_range);
                return AE_ERROR;
        }
        req->io_type = SERIAL_IO_MEM;

Russell King

2003-10-06 08:38 UTC #1 lore raw

Quoted 3 lines · Dmitry Torokhov

Lastest changes in 8250_acpi.c produce warnings about type mismatch in printk. We could either change format to print long long arguments or, until most of us are on 64 bits, just trim values to 32.

I'd like Bjorn to comment before I apply this.

drivers/serial/8250_acpi.c Mon Oct 6 01:18:22 2003 renamed from drivers/serial/8250_acpi.c Wed Oct 1 04:11:17 2003 +3 -2

@@ -28,8 +28,9 @@
        req->iomem_base = ioremap(req->iomap_base, size);
        if (!req->iomem_base) {
                printk(KERN_ERR "%s: couldn't ioremap 0x%lx-0x%lx\n",
-                       __FUNCTION__, addr->min_address_range,
-                       addr->max_address_range);
+                       __FUNCTION__,
+                       (unsigned long)addr->min_address_range,
+                       (unsigned long)addr->max_address_range);
                return AE_ERROR;
        }
        req->io_type = SERIAL_IO_MEM;

Signature · 4 lines

Russell King ([email protected])	http://www.arm.linux.org.uk/personal/
      Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
      maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                      2.6 Serial core

Bjorn Helgaas

2003-10-06 16:07 UTC #2 lore raw

Quoted 6 lines · Russell King

Quoted 3 lines · Dmitry Torokhov
Lastest changes in 8250_acpi.c produce warnings about type mismatch in printk. We could either change format to print long long arguments or, until most of us are on 64 bits, just trim values to 32.
I'd like Bjorn to comment before I apply this.

Oops, sorry about that. Here's my preference for fixing it:

===== drivers/serial/8250_acpi.c 1.3 vs edited =====

drivers/serial/8250_acpi.c +1 -2

@@ -28,8 +28,7 @@
 	req->iomem_base = ioremap(req->iomap_base, size);
 	if (!req->iomem_base) {
 		printk(KERN_ERR "%s: couldn't ioremap 0x%lx-0x%lx\n",
-			__FUNCTION__, addr->min_address_range,
-			addr->max_address_range);
+			__FUNCTION__, req->iomap_base, req->iomap_base + size);
 		return AE_ERROR;
 	}
 	req->io_type = SERIAL_IO_MEM;