Skip to contentSkip to conversation

Fix 64bit warnings in rtl8139too

PATCH In review Andi Kleen 3 participants 3 messages Oct 7, 2003 – Oct 14, 2003

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Andi Kleen

author
#0 lore raw

PATCH 1/1 Fix 64bit warnings in rtl8139too

Fix a harmless 64bit pointer/integer mismatch warning in 8139too.

drivers/net/8139too.c renamed from drivers/net/8139too.c-o +2 -1
diff -u linux-2.5-cleanup/drivers/net/8139too.c-o linux-2.5-cleanup/drivers/net/8139too.c
@@ -746,7 +746,8 @@
 	u8 tmp8;
 	int rc;
 	unsigned int i;
-	u32 pio_start, pio_end, pio_flags, pio_len;
+	unsigned long pio_start;
+	u32 pio_end, pio_flags, pio_len;
 	unsigned long mmio_start, mmio_end, mmio_flags, mmio_len;
 	u32 version;
#1 lore raw
Quoted 6 lines · Andi Kleen

Fix a harmless 64bit pointer/integer mismatch warning in 8139too.

diff -u linux-2.5-cleanup/drivers/net/8139too.c-o linux-2.5-cleanup/drivers/net/8139too.c

drivers/net/8139too.c line 752

Quoted 8 lines
drivers/net/8139too.c renamed from drivers/net/8139too.c-o +2 -1
@@ -746,7 +746,8 @@
 	u8 tmp8;
 	int rc;
 	unsigned int i;
-	u32 pio_start, pio_end, pio_flags, pio_len;
+	unsigned long pio_start;
+	u32 pio_end, pio_flags, pio_len;
 	unsigned long mmio_start, mmio_end, mmio_flags, mmio_len;
 	u32 version;

Why not just make this look like mmio_*?

Jeff

#2 lore raw
Quoted 13 lines · Jeff Garzik
Quoted 12 lines · Andi Kleen

Fix a harmless 64bit pointer/integer mismatch warning in 8139too.

diff -u linux-2.5-cleanup/drivers/net/8139too.c-o
linux-2.5-cleanup/drivers/net/8139too.c
--- linux-2.5-cleanup/drivers/net/8139too.c-o 2003-09-08
00:02:03.000000000 +0200
+++ linux-2.5-cleanup/drivers/net/8139too.c 2003-12-02
17:13:24.634752560 +0100

drivers/net/8139too.c renamed from drivers/net/8139too.c-o +0 -0
@@ -746,7 +746,8 @@
 	u8 tmp8;
 	int rc;
 	unsigned int i;
Quoted 8 lines

drivers/net/8139too.c line 752

Quoted 5 lines
drivers/net/8139too.c renamed from drivers/net/8139too.c-o +2 -1
-	u32 pio_start, pio_end, pio_flags, pio_len;
+	unsigned long pio_start;
+	u32 pio_end, pio_flags, pio_len;
 	unsigned long mmio_start, mmio_end, mmio_flags, mmio_len;
 	u32 version;

Why not just make this look like mmio_*?

No problems, feel free to do that.

I just did the minimal change to fix the warning.

-Andi