i2c-sis630 fixes for 2.6.0-test7

PATCH New Alexander Malysh 2 participants 4 messages May 19, 2005

lore

Share & tools

lore

Alexander Malysh

author

2005-05-19 06:24 UTC #0 lore raw

PATCH 1/1 i2c-sis630 fixes for 2.6.0-test7

Hi Greg,

attached you can find a patch that should fix i2c-sis630 driver for 2.6.0-X kernel. With i2c-sis630 from stock 2.6.0-X we have oops and driver was not correct registered against i2c-core.

Changes:
1) fixed a oops while modprobing
2) added check for buffer overflow for i2c block data read transaction
3) added 'force' modprobe parameter. It's allow more easily testing for not
yet supported SiS chips.

Please apply... Thanks.

Signature · 10 lines

Best regards,
Dipl.-Ing.
Alexander Malysh
-------------- next part --------------
A non-text attachment was scrubbed...
Name: i2c-sis630.diff
Type: text/x-diff
Size: 5640 bytes
Desc: not available
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20031010/3ae9d41c/i2c-sis630.bin

Greg KH

2005-05-19 06:24 UTC #1 lore raw

PATCH 1/1 i2c-sis630 fixes for 2.6.0-test7

Quoted 6 lines · Alexander Malysh

Hi Greg,
attached you can find a patch that should fix i2c-sis630 driver for 2.6.0-X kernel. With i2c-sis630 from stock 2.6.0-X we have oops and driver was not correct registered against i2c-core.

Quoted 7 lines

Changes:
1) fixed a oops while modprobing
2) added check for buffer overflow for i2c block data read transaction
3) added 'force' modprobe parameter. It's allow more easily testing for not
yet supported SiS chips.
Please apply... Thanks.

Why did you add a printk() call right before a call to dev_err()? Can you remove that change and resubmit the patch?

thanks,

greg k-h

Alexander Malysh

author

2005-05-19 06:24 UTC #2 lore raw

PATCH 1/1 i2c-sis630 fixes for 2.6.0-test7

In reply to Alexander Malysh

Quoted 13 lines · Greg KH

Quoted 12 lines · Alexander Malysh
Hi Greg,
attached you can find a patch that should fix i2c-sis630 driver for 2.6.0-X kernel. With i2c-sis630 from stock 2.6.0-X we have oops and driver was not correct registered against i2c-core.
Changes:
1) fixed a oops while modprobing
2) added check for buffer overflow for i2c block data read transaction
3) added 'force' modprobe parameter. It's allow more easily testing for
not yet supported SiS chips.

Quoted 4 lines

Quoted 1 line
Please apply... Thanks.
Why did you add a printk() call right before a call to dev_err()? Can you remove that change and resubmit the patch?

oops, sorry. It was for debugging...
corrected patch attached.

Quoted 4 lines

thanks,
greg k-h

Signature · 10 lines

Best regards,
Dipl.-Ing.
Alexander Malysh
-------------- next part --------------
A non-text attachment was scrubbed...
Name: i2c-sis630.diff
Type: text/x-diff
Size: 5604 bytes
Desc: not available
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20031010/7acdd40a/i2c-sis630.bin

Greg KH

2005-05-19 06:24 UTC #3 lore raw

PATCH 1/1 i2c-sis630 fixes for 2.6.0-test7

In reply to Alexander Malysh

Quoted 14 lines · Alexander Malysh

Quoted 13 lines · Greg KH
Quoted 12 lines · Alexander Malysh
Hi Greg,
attached you can find a patch that should fix i2c-sis630 driver for 2.6.0-X kernel. With i2c-sis630 from stock 2.6.0-X we have oops and driver was not correct registered against i2c-core.
Changes:
1) fixed a oops while modprobing
2) added check for buffer overflow for i2c block data read transaction
3) added 'force' modprobe parameter. It's allow more easily testing for
not yet supported SiS chips.

Quoted 7 lines

Quoted 4 lines
Quoted 1 line
Please apply... Thanks.
Why did you add a printk() call right before a call to dev_err()? Can you remove that change and resubmit the patch?
oops, sorry. It was for debugging...
corrected patch attached.

Thanks, I've applied this and will send it on up the food chain.

greg k-h