Sysdeps changes for hppa.
PATCH 1/1 Sysdeps changes for hppa.
libc-alpha,
Generic defines JUMPTARGET, so we must undefine it before setting it to nothing in sysdeps/hppa/sysdep.h.
Secondly, there were a lot of missing macro's in sysdep/unix/sysv/linux/hppa/sysdep.h, the second bit of the patch takes care of defining those properly for hppa and cleans up the file itself in a more logical layout.
The last patch makes sure that syscall in sysdep.c takes advantage of all the fixes for PIC register bugs I had to track down.
Cheers,
Carlos.
===
sysdeps/hppa/sysdep.h | 1 sysdeps/unix/sysv/linux/hppa/sysdep.h | 274 ++++++++-- sysdeps/unix/sysv/linux/hppa/sysdep.c | 46 + 3 files changed, 254 insertions(+), 67 deletions(-)
===
2003-10-12 Carlos O'Donell <[email protected]>
* sysdeps/hppa/sysdep.h: Undef JUMPTARGET before use.
* sysdeps/unix/sysv/linux/hppa/sysdep.h:
Define __NR_semtimedop for compat with old kernels, PSEUDO_ERRVAL, SYSCALL_ERROR_LABEL under all conditions, INTERNAL_SYSCALL_DECL, INTERNAL_SYSCALL_ERROR_P, INTERNAL_SYSCALL_ERRNO, INTERNAL_SYSCALL, and undef JUMPTARGET before use.
[PIC]: Save pic register around syscall.
* sysdeps/unix/sysv/linux/hppa/sysdep.c (syscall):
Cleanup asm statment.
sysdeps/hppa/sysdep.h +1 -0
@@ -70,6 +67,7 @@#define PSEUDO_END (name) \ END (name) +#undef JUMPTARGET#define JUMPTARGET (name) name#define SYSCALL_PIC_SETUP /* Nothing. */
sysdeps/unix/sysv/linux/hppa/sysdep.h +225 -49
341 lines not on this page · raw message
sysdeps/unix/sysv/linux/hppa/sysdep.c +28 -18
59 lines not on this page · raw message
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 12 lines
2003-10-12 Carlos O'Donell <[email protected]>
*
sysdeps/hppa/sysdep.h: Undef JUMPTARGET before use.
*sysdeps/unix/sysv/linux/hppa/sysdep.h:
Define__NR_semtimedopfor compat with old kernels,PSEUDO_ERRVAL,SYSCALL_ERROR_LABELunder all conditions,INTERNAL_SYSCALL_DECL,INTERNAL_SYSCALL_ERROR_P,INTERNAL_SYSCALL_ERRNO,INTERNAL_SYSCALL, and undef JUMPTARGET before use.
[PIC]: Save pic register around syscall.
*sysdeps/unix/sysv/linux/hppa/sysdep.c(syscall):
Cleanup asm statment.
I've applied this patch, but only because I really don't care how the PA port looks.
The semtimedop definition is completely wrong. If you want all syscall,s use appropriate headers.
You've modified the patch by hand and broke it, forcing me to do clean up.
The coding style is completely wrong and a terrible mess. The coding standard document is available, read it.
The preprocessor directive indentation is wrong or non-existing.
- --
- --------------. ,-. 444 Castro Street
Ulrich Drepper \ ,-----------------' \ Mountain View, CA 94041 USA
Red Hat --' drepper at redhat.com ---------------------------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
iD8DBQE/jN/W2ijCOnn/RHQRAjrzAJsEI3ukb5MQ/T0Wl0ihUX1l2ejBJACeL8GW 7tzXLthx8pW4Rhb+26NQkH4=
=8Fy5
-----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 12 lines
2003-10-12 Carlos O'Donell <[email protected]>
*
sysdeps/hppa/sysdep.h: Undef JUMPTARGET before use.
*sysdeps/unix/sysv/linux/hppa/sysdep.h:
Define__NR_semtimedopfor compat with old kernels,PSEUDO_ERRVAL,SYSCALL_ERROR_LABELunder all conditions,INTERNAL_SYSCALL_DECL,INTERNAL_SYSCALL_ERROR_P,INTERNAL_SYSCALL_ERRNO,INTERNAL_SYSCALL, and undef JUMPTARGET before use.
[PIC]: Save pic register around syscall.
*sysdeps/unix/sysv/linux/hppa/sysdep.c(syscall):
Cleanup asm statment.
I've applied this patch, but only because I really don't care how the PA port looks.
The semtimedop definition is completely wrong. If you want all syscall,s use appropriate headers.
You've modified the patch by hand and broke it, forcing me to do clean up.
The coding style is completely wrong and a terrible mess. The coding standard document is available, read it.
The preprocessor directive indentation is wrong or non-existing.
- --
- --------------. ,-. 444 Castro Street
Ulrich Drepper \ ,-----------------' \ Mountain View, CA 94041 USA
Red Hat --' drepper at redhat.com ---------------------------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
iD8DBQE/jN/W2ijCOnn/RHQRAjrzAJsEI3ukb5MQ/T0Wl0ihUX1l2ejBJACeL8GW 7tzXLthx8pW4Rhb+26NQkH4=
=8Fy5
-----END PGP SIGNATURE-----
Ulrich,
Quoted 2 lines
I've applied this patch, but only because I really don't care how the PA port looks.
I didn't think the patch was too ugly, but then again a father thinks all his children are beautiful.
Quoted 2 lines
The semtimedop definition is completely wrong. If you want all syscall,s use appropriate headers.
Moot point. We know why it's there, because changes don't propagate everywhere as fast as we'd like.
Quoted 1 line
You've modified the patch by hand and broke it, forcing me to do clean up.
Unforgivable. Please reject patches immediately if this happens again. I will produce a correct patch.
Quoted 2 lines
The coding style is completely wrong and a terrible mess. The coding standard document is available, read it.
Suggestions accepted. I will reread the document.
Quoted 1 line
The preprocessor directive indentation is wrong or non-existing.
Never non-existent. Incorrect yes.
Cheers,
Carlos.
Ulrich,
Quoted 2 lines
I've applied this patch, but only because I really don't care how the PA port looks.
I didn't think the patch was too ugly, but then again a father thinks all his children are beautiful.
Quoted 2 lines
The semtimedop definition is completely wrong. If you want all syscall,s use appropriate headers.
Moot point. We know why it's there, because changes don't propagate everywhere as fast as we'd like.
Quoted 1 line
You've modified the patch by hand and broke it, forcing me to do clean up.
Unforgivable. Please reject patches immediately if this happens again. I will produce a correct patch.
Quoted 2 lines
The coding style is completely wrong and a terrible mess. The coding standard document is available, read it.
Suggestions accepted. I will reread the document.
Quoted 1 line
The preprocessor directive indentation is wrong or non-existing.
Never non-existent. Incorrect yes.
Cheers,
Carlos.
Quoted 2 lines
I've applied this patch, but only because I really don't care how the PA port looks.
Small cleanup mistake. Thank you.
c.
---
2003-10-18 Carlos O'Donell <[email protected]>
* sysdeps/unix/sysv/linux/hppa/sysdep.h: Fix merge error.
sysdeps/unix/sysv/linux/hppa/sysdep.h +0 -1
@@ -371,7 +371,6 @@ LDW_ASM_PIC \ : "=r" (__res) \ : "i" (SYS_ify(name)) ASM_ARGS_##nr \ -); \ : CALL_CLOB_REGS CLOB_ARGS_##nr \ ); \ __sys_res = (long)__res; \
Quoted 2 lines
I've applied this patch, but only because I really don't care how the PA port looks.
Small cleanup mistake. Thank you.
c.
---
2003-10-18 Carlos O'Donell <[email protected]>
* sysdeps/unix/sysv/linux/hppa/sysdep.h: Fix merge error.
sysdeps/unix/sysv/linux/hppa/sysdep.h +0 -1
@@ -371,7 +371,6 @@ LDW_ASM_PIC \ : "=r" (__res) \ : "i" (SYS_ify(name)) ASM_ARGS_##nr \ -); \ : CALL_CLOB_REGS CLOB_ARGS_##nr \ ); \ __sys_res = (long)__res; \