qlogic_cs: init legacy_hosts

PATCH In review Aristeu Sergio Rozanski Filho 2 participants 5 messages Oct 20, 2003 – Oct 21, 2003 SCSI

lore

Share & tools

lore

Aristeu Sergio Rozanski Filho

author

2003-10-20 23:26 UTC #0 lore raw

PATCH 1/1 qlogic_cs: init legacy_hosts

Signature · 1 line

aris

drivers/scsi/pcmcia/qlogic_stub.c renamed from drivers/scsi/pcmcia/qlogic_stub.c.orig +2 -0

@@ -249,6 +249,8 @@
 	else
 		qlogicfas_preset(link->io.BasePort1, link->irq.AssignedIRQ);
 
+	INIT_LIST_HEAD(&qlogicfas_driver_template.legacy_hosts);
+
 	host = __qlogicfas_detect(&qlogicfas_driver_template);
 	if (!host) {
 		printk(KERN_INFO "qlogic_cs: no SCSI devices found\n");

Christoph Hellwig

2003-10-21 08:11 UTC #1 lore raw

drivers/scsi/pcmcia/qlogic_stub.c line 253

Quoted 12 lines · Aristeu Sergio Rozanski Filho

Signature · 1 line
aris
drivers/scsi/pcmcia/qlogic_stub.c renamed from drivers/scsi/pcmcia/qlogic_stub.c.orig +2 -0
@@ -249,6 +249,8 @@
 	else
 		qlogicfas_preset(link->io.BasePort1, link->irq.AssignedIRQ);
 
+	INIT_LIST_HEAD(&qlogicfas_driver_template.legacy_hosts);
+

qlogic_cs is a newstyle driver, no need to initialize it.

Aristeu Sergio Rozanski Filho

author

2003-10-21 09:33 UTC #2 lore raw

hi Christoph,

Quoted 8 lines

drivers/scsi/pcmcia/qlogic_stub.c line 253
Quoted 6 lines
drivers/scsi/pcmcia/qlogic_stub.c renamed from drivers/scsi/pcmcia/qlogic_stub.c.orig +2 -0
@@ -249,6 +249,8 @@
 	else
 		qlogicfas_preset(link->io.BasePort1, link->irq.AssignedIRQ);
 
+	INIT_LIST_HEAD(&qlogicfas_driver_template.legacy_hosts);
+
qlogic_cs is a newstyle driver, no need to initialize it.

then it needs more work. without initializing it i get an oops in scsi_register(). i guess the qlogic_cs is an oldstyle driver by now because it uses qlogicfas template and functions.

--
aris

Christoph Hellwig

2003-10-21 09:58 UTC #3 lore raw

Quoted 5 lines · Aristeu Sergio Rozanski Filho

hi Christoph,
Quoted 4 lines
Quoted 4 lines
drivers/scsi/pcmcia/qlogic_stub.c renamed from drivers/scsi/pcmcia/qlogic_stub.c.orig +0 -0
@@ -249,6 +249,8 @@
 	else
 		qlogicfas_preset(link->io.BasePort1, link->irq.AssignedIRQ);
 

Quoted 7 lines

Quoted 4 lines
drivers/scsi/pcmcia/qlogic_stub.c line 253
Quoted 2 lines
drivers/scsi/pcmcia/qlogic_stub.c renamed from drivers/scsi/pcmcia/qlogic_stub.c.orig +2 -0
+	INIT_LIST_HEAD(&qlogicfas_driver_template.legacy_hosts);
+
qlogic_cs is a newstyle driver, no need to initialize it.
then it needs more work. without initializing it i get an oops in scsi_register(). i guess the qlogic_cs is an oldstyle driver by now because it uses qlogicfas template and functions.

why do you call scsi_register at all? You need to uses scsi_host_alloc in the pcmcia case.

Aristeu Sergio Rozanski Filho

author

2003-10-21 10:11 UTC #4 lore raw

Quoted 7 lines

Quoted 4 lines
Quoted 1 line
qlogic_cs is a newstyle driver, no need to initialize it.
then it needs more work. without initializing it i get an oops in scsi_register(). i guess the qlogic_cs is an oldstyle driver by now because it uses qlogicfas template and functions.
why do you call scsi_register at all? You need to uses scsi_host_alloc in the pcmcia case.

actually qlogic_cs calls __qlogicfas_detect() that calls scsi_register(). i'll work on this.

Signature · 1 line

aris