Skip to contentSkip to conversation

bug in ens1371/ens1370 joystick driver

DISCUSSION Juan Linietsky 2 participants 2 messages Oct 23, 2003

lore
Share & tools
lore
#0 lore raw

I apologize for not being able to send patches, but I dont know how to proper fix this.

The ens1371 driver takes a joystick_port parameter with range 1..8 but that same parameter is them put into a switch to detect io port values like 0x200, 0x208, etc. so the joystick will never be detected. I somewhat fixed this myself by forcing 0x200 as parameter and it worked well afterwards.

I hope this report is of any help
regards

Juan Linietsky

-------------------------------------------------------
This SF.net email is sponsored by OSDN developer relations Here's your chance to show off your extensive product knowledge We want to know what you know. Tell us and you have a chance to win $100
http://www.zoomerang.com/survey.zgi?HRPT1X3RYQNC5V4MLNSV3E54

#1 lore raw
Quoted 3 lines · Juan Linietsky

The ens1371 driver takes a joystick_port parameter with range 1..8 but that same parameter is them put into a switch to detect io port values like 0x200, 0x208, etc. so the joystick will never be detected.

ens1370.c says:
MODULE_PARM(joystick_port, "1-" __MODULE_STRING(SNDRV_CARDS) "i"); MODULE_PARM_DESC(joystick_port, "Joystick port address."); MODULE_PARM_SYNTAX(joystick_port, SNDRV_ENABLED

	",allows:{{0},{0x200},{0x208},{0x210},{0x218}},dialog:list");

The range 1..8 means that it's possible to specify a parameter value for each of the up to 8 cards (SNDRV_CARDS is defined as 8). The parameter itself takes the correct values.

Regards,
Clemens

-------------------------------------------------------
This SF.net email is sponsored by OSDN developer relations Here's your chance to show off your extensive product knowledge We want to know what you know. Tell us and you have a chance to win $100
http://www.zoomerang.com/survey.zgi?HRPT1X3RYQNC5V4MLNSV3E54