incorrect function declaration for claim()

PATCH In review Olaf Hering 2 participants 2 messages Nov 6, 2003

lore

Share & tools

lore

Olaf Hering

author

2003-11-06 20:24 UTC #0 lore raw

PATCH 1/1 incorrect function declaration for claim()

its void * in start.c

arch/ppc/boot/chrp/main.c renamed from arch/ppc/boot/chrp/main.c~ +1 -1

@@ -17,7 +17,7 @@ extern char _start, _end;
 
 extern int getprop(void *, const char *, void *, int);
 extern unsigned int heap_max;
-extern void claim(unsigned int virt, unsigned int size, unsigned int align);
+extern void *claim(unsigned int virt, unsigned int size, unsigned int align);
 extern void *finddevice(const char *);
 extern void flush_cache(void *, unsigned long);
 extern void gunzip(void *, int, unsigned char *, int *);

--
USB is for mice, FireWire is for men!

sUse lINUX ag, nÜRNBERG

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Sam Ravnborg

2003-11-06 22:31 UTC #1 lore raw

arch/ppc/boot/chrp/main.c extern char _start, _end; · line 23

Quoted 10 lines · Olaf Hering

+++ linux-2.4/arch/ppc/boot/chrp/main.c 2003-11-06 21:21:26.000000000 +0100

arch/ppc/boot/chrp/main.c renamed from arch/ppc/boot/chrp/main.c~ +1 -1

@@ -17,7 +17,7 @@ extern char _start, _end;
 
 extern int getprop(void *, const char *, void *, int);
 extern unsigned int heap_max;
-extern void claim(unsigned int virt, unsigned int size, unsigned int align);
+extern void *claim(unsigned int virt, unsigned int size, unsigned int align);
 extern void *finddevice(const char *);
 extern void flush_cache(void *, unsigned long);
 extern void gunzip(void *, int, unsigned char *, int *);

In general I consider it a bug to have prototypes in a .c file....

Sam

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/