Skip to contentSkip to conversation

2.4 lacks dummy SET_NETDEV_DEV

PATCH In review Pekka Pietikainen 2 participants 5 messages Nov 10, 2003 – Dec 2, 2003

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Pekka Pietikainen

author
#0 lore raw

PATCH 1/1 2.4 lacks dummy SET_NETDEV_DEV

Just noticed that 2.4 doesn't have a dummy SET_NETDEV_DEV for drivers written for 2.6 (like the b44 fixes that got merged a few days back, so it wouldn't actually compile :-) )

include/linux/netdevice.h 2003-11-10 20:12:46.480609408 +0200 renamed from include/linux/netdevice.h.orig 2003-10-03 20:30:14.000000000 +0300 +2 -0
@@ -454,6 +454,8 @@
 #endif /* CONFIG_NET_DIVERT */
 };
  
+/* 2.6 compatibility */
+#define SET_NETDEV_DEV(net, pdev) do { } while (0)
  
 struct packet_type
 {
author
#1 lore raw
Quoted 3 lines · Pekka Pietikainen

Just noticed that 2.4 doesn't have a dummy SET_NETDEV_DEV for drivers written for 2.6 (like the b44 fixes that got merged a few days back, so it wouldn't actually compile :-) )

Ah, except Jeff merged a version without the call so there should be no problem :-) (I still like the idea of being able to use exactly the same driver source on 2.4/2.6 though)

#2 lore raw
Quoted 2 lines · On Tue, 11 Nov 2003 00:14:30 +0200 Pekka Pietikainen <[email protected]> wrote:

(I still like the idea of being able to use exactly the same driver source on 2.4/2.6 though)

I agree, someone should merge in the dummy SET_NETDEV_DEV once Marcelo starts up 2.4.24-preX

author
#3 lore raw
Quoted 8 lines · David S. Miller
Quoted 2 lines · On Tue, 11 Nov 2003 00:14:30 +0200 Pekka Pietikainen <[email protected]> wrote:

(I still like the idea of being able to use exactly the same driver source on 2.4/2.6 though)

I agree, someone should merge in the dummy SET_NETDEV_DEV once Marcelo starts up 2.4.24-preX

Ping :-)

include/linux/netdevice.h renamed from include/linux/netdevice.h.orig +2 -0
@@ -456,6 +456,8 @@
 #endif /* CONFIG_NET_DIVERT */
 };
 
+/* 2.6 compatibility */
+#define SET_NETDEV_DEV(net, pdev) do { } while (0)
 
 struct packet_type 
 {
Signature · 1 line
Pekka Pietikainen
#4 lore raw
Quoted 5 lines · On Tue, 2 Dec 2003 12:40:25 +0200 Pekka Pietikainen <[email protected]> wrote:
Quoted 2 lines · David S. Miller

I agree, someone should merge in the dummy SET_NETDEV_DEV once Marcelo starts up 2.4.24-preX

Ping :-)

Yes Marcelo, please apply this.

Quoted 11 lines
include/linux/netdevice.h renamed from include/linux/netdevice.h.orig +2 -0
@@ -456,6 +456,8 @@
 #endif /* CONFIG_NET_DIVERT */
 };
 
+/* 2.6 compatibility */
+#define SET_NETDEV_DEV(net, pdev) do { } while (0)
 
 struct packet_type 
 {