Skip to contentSkip to conversation

2.6 eicon/ and hardware/eicon/ drivers using the samesymbols (fwd)

PATCH Adrian Bunk 2 participants 2 messages Nov 12, 2003

lore
Share & tools
lore
#0 lore raw

The patch forwarded below is still required in -test9.

Please apply
Adrian

----- Forwarded message from Armin Schindler <[email protected]> -----

Date: Thu, 25 Sep 2003 13:33:53 +0200 (MEST)
From: Armin Schindler <[email protected]>
To: Adrian Bunk <[email protected]>
Cc: <[email protected]>,
Linux Kernel Mailinglist <[email protected]>
Subject: [PATCH] Re: 2.6 eicon/ and hardware/eicon/ drivers using the samesymbols

Quoted 7 lines · Adrian Bunk

I got the link error below in 2.6.0-test5-mm4 (but it doesn't seem to be specific to -mm).

It seems some drivers under eicon/ and hardware/eicon/ use the same symbols. Either some symbols should be renamed or Kconfig dependencies should ensure that you can't build two such drivers statically into the kernel at the same time.

The legacy eicon driver in drivers/isdn/eicon is the old one and will be removed as soon as all features went to the new driver. Anyway this old driver was never meant to be non-module.

This patch should do it.

Armin

drivers/isdn/eicon/Kconfig renamed from drivers/isdn/eicon/Kconfig.orig +1 -1
@@ -13,7 +13,7 @@
 choice
 	prompt "Eicon active card support"
 	optional
-	depends on ISDN_DRV_EICON && ISDN
+	depends on ISDN_DRV_EICON && ISDN && m
 
 config ISDN_DRV_EICON_DIVAS
 	tristate "Eicon driver"

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

----- End forwarded message -----

#1 lore raw

I already send a patch to Linus and asked him to remove the old driver in drivers/isdn/eicon.

The new driver in drivers/isdn/hardware/eicon will take over for the Eicon ISDN PCI cards including a lot of new features.

Armin

Quoted 60 lines · Adrian Bunk

The patch forwarded below is still required in -test9.

Please apply
Adrian

----- Forwarded message from Armin Schindler <[email protected]> -----

Date: Thu, 25 Sep 2003 13:33:53 +0200 (MEST)
From: Armin Schindler <[email protected]>
To: Adrian Bunk <[email protected]>
Cc: <[email protected]>,
Linux Kernel Mailinglist <[email protected]>
Subject: [PATCH] Re: 2.6 eicon/ and hardware/eicon/ drivers using the samesymbols

Quoted 7 lines · Adrian Bunk

I got the link error below in 2.6.0-test5-mm4 (but it doesn't seem to be specific to -mm).

It seems some drivers under eicon/ and hardware/eicon/ use the same symbols. Either some symbols should be renamed or Kconfig dependencies should ensure that you can't build two such drivers statically into the kernel at the same time.

The legacy eicon driver in drivers/isdn/eicon is the old one and will be removed as soon as all features went to the new driver. Anyway this old driver was never meant to be non-module.

This patch should do it.

Armin

drivers/isdn/eicon/Kconfig renamed from drivers/isdn/eicon/Kconfig.orig +1 -2
@@ -13,7 +13,7 @@
 choice
 	prompt "Eicon active card support"
 	optional
-	depends on ISDN_DRV_EICON && ISDN
+	depends on ISDN_DRV_EICON && ISDN && m
 
 config ISDN_DRV_EICON_DIVAS
 	tristate "Eicon driver"
 
-

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

----- End forwarded message -----

_______________________________________________
isdn4linux mailing list
[email protected]
https://www.isdn4linux.de/mailman/listinfo/isdn4linux