Skip to contentSkip to conversation

[2.6] Nonsense-messages from iptables + co.

DISCUSSION Matthias Andree 7 participants 8 messages Nov 14, 2003 netfilter

lore
Share & tools
lore
#0 lore raw

Who the heck added these unhelpful

"ipt_hook: happy cracking."

messages to iptables/mangling/connection tracking code? There are three instances.

If the kernel has got something to say, it should be clear what the kernel means, say, maximum <whatever> rate exceeded or something, not such junk like this.

This is IMHO a MUST-FIX before 2.6.0.

Signature · 3 lines
Matthias Andree

Encrypt your mail: my GnuPG key ID is 0x052E7D95
#1 lore raw
Quoted 4 lines · Matthias Andree

Who the heck added these unhelpful

"ipt_hook: happy cracking."

Quoted 10 lines

messages to iptables/mangling/connection tracking code? There are three instances.

If the kernel has got something to say, it should be clear what the kernel means, say, maximum <whatever> rate exceeded or something, not such junk like this.

This is IMHO a MUST-FIX before 2.6.0.

The bug that led to that message is already fixed. The message itself might be stupid but is definitely not a must-fix item. Also, instead of changing the message statistics should be added to conntrack etc. to count unusual events instead of printing them to the console.

Best regards,
Patrick

#2 lore raw
In reply to Matthias Andree
Quoted 6 lines · Matthias Andree

Who the heck added these unhelpful

"ipt_hook: happy cracking."

messages to iptables/mangling/connection tracking code? There are three instances.

I guess it was Rusty. The idea message is a funny way of telling you that you are sending incomplete ip headers. Something that is not likely to occur unless you are trying to send corrupt packets via raw ip sockets...

Quoted 3 lines

If the kernel has got something to say, it should be clear what the kernel means, say, maximum <whatever> rate exceeded or something, not such junk like this.

There are people who do actually have fun developing linux code. And Rusty has a peculiar sense of humor... for further reference see the comments like 'furniture shopping' throughout the netfilter/iptables source code. I sometimes wish I had the same humor like he has.

Yes, I know. Stuff like this is not exactly useful in error messages. I'd say it's one of the few remainders of the 2.3.x early development time. Like the "Rusty's brain broke" messages that have recently been removed/replaced.

btw: *nix has a long history of funny error messages, like 'printer on fire' or others.

Quoted 1 line

This is IMHO a MUST-FIX before 2.6.0.

It is even in 2.4.x, where it could have been fixed throughout the last couple of years. Nobody else has yet complained.

Quoted 1 line

Matthias Andree

Signature · 3 lines
- Harald Welte <[email protected]>               http://www.gnumonks.org/
============================================================================
Programming is like sex: One mistake and you have to support it your lifetime
#3 lore raw
Quoted 6 lines · Harald Welte
Quoted 1 line

"ipt_hook: happy cracking."

I guess it was Rusty. The idea message is a funny way of telling you that you are sending incomplete ip headers. Something that is not likely to occur unless you are trying to send corrupt packets via raw ip sockets...

Actually, once I found the message, and saw the context, it was actually clear and self-explanatory. It was actually the ipfilter code's fault that it got generated in any context other than "trying to send an intentionall busticated packet"...

Quoted 4 lines

There are people who do actually have fun developing linux code. And Rusty has a peculiar sense of humor... for further reference see the comments like 'furniture shopping' throughout the netfilter/iptables source code. I sometimes wish I had the same humor like he has.

find arch/sparc* -name '*.[ch]'| xargs grep -i penguin

and then read through the files that finds (trap.c is particularly fun).

Somebody was having fun porting. ;)

#4 lore raw
In reply to Harald Welte
Quoted 4 lines
Quoted 1 line

This is IMHO a MUST-FIX before 2.6.0.

It is even in 2.4.x, where it could have been fixed throughout the last couple of years. Nobody else has yet complained.

Well, I have noticed an increased amount of these 2 weeks ago, and I belive it was Patrick McHardy, who found a bug that could cause these to show, when no root process was creating any invalid packets.

AFAIK, it has been fixed in 2.6.0-test9-bk16 or around that.

The message stays though :-)

Maciej.

#5 lore raw
In reply to Harald Welte
Quoted 10 lines · Harald Welte
Quoted 6 lines · Matthias Andree

Who the heck added these unhelpful

"ipt_hook: happy cracking."

messages to iptables/mangling/connection tracking code? There are three instances.

I guess it was Rusty. The idea message is a funny way of telling you that you are sending incomplete ip headers.

Am I? what's with the *_limit() function called before the printk?

Quoted 3 lines

Something that is not
likely to occur unless you are trying to send corrupt packets via raw ip sockets...

Not at the times when these occurred.

Quoted 9 lines
Quoted 3 lines

If the kernel has got something to say, it should be clear what the kernel means, say, maximum <whatever> rate exceeded or something, not such junk like this.

There are people who do actually have fun developing linux code. And Rusty has a peculiar sense of humor... for further reference see the comments like 'furniture shopping' throughout the netfilter/iptables source code. I sometimes wish I had the same humor like he has.

Quoted 7 lines

Yes, I know. Stuff like this is not exactly useful in error messages. I'd say it's one of the few remainders of the 2.3.x early development time. Like the "Rusty's brain broke" messages that have recently been removed/replaced.

btw: *nix has a long history of funny error messages, like 'printer on fire' or others.

I don't mind having fun developing or placing funny error messages, and I hadn't taken that as "serious problem" message but rather as "someone in the wild tries to cheat on us" but how do I know? I'm a bit more cautious with network related stuff, particular with packet filtering and things like that. I'd suggest that the fun be put in the comments, or that funny error messages are accompanied by a plain text explanation in parentheses, or there is at least a "dictionary" of error messages in the comments of the *.c files that a geek could find...

#6 lore raw
Quoted 4 lines · Matthias Andree
Quoted 2 lines

I guess it was Rusty. The idea message is a funny way of telling you that you are sending incomplete ip headers.

Am I? what's with the *_limit() function called before the printk?

it's a generic network rate limiting function. It prevents the same message from being logged and logged again (and thus flooding your syslog).

Quoted 4 lines
Quoted 2 lines

Something that is not likely to occur unless you are trying to send corrupt packets via raw ip sockets...

Not at the times when these occurred.

there seemed to be a bug that I was unaware of, and according to other mails in this thread it has been fixed.

Signature · 5 lines
- Harald Welte <[email protected]>             http://www.netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie
#7 lore raw
In reply to Matthias Andree
Quoted 7 lines · On Nov-14 2003, Fri, 14:20 +0100 Matthias Andree <[email protected]> wrote:

Who the heck added these unhelpful

"ipt_hook: happy cracking."

If the kernel has got something to say, it should be clear what the kernel means, say, maximum <whatever> rate exceeded or something, not such junk like this.

fprintf(stderr, "user lacks sense of humor, killing thread.\n");