Skip to contentSkip to conversation

cleanups for input

PATCH Pavel Machek 1 participant 1 message Nov 16, 2003 Input drivers

lore
Share & tools
lore
#0 lore raw

Hi!

I know cleanups are not wanted just now, but I'd like this queued...

GFP_ATOMIC can fail at any time; I believe we do not want "heisenbugs" so we should at least warn.

[serio_rescan() does not return error value yet it can fail. It seems pretty broken to me :-(.]

drivers/input/serio/serio.c renamed from linux/drivers/input/serio/serio.c +3 -1
@@ -134,8 +134,10 @@
 {
 	struct serio_event *event;
 
-	if (!(event = kmalloc(sizeof(struct serio_event), GFP_ATOMIC)))
+	if (!(event = kmalloc(sizeof(struct serio_event), GFP_ATOMIC))) {
+		printk(KERN_CRIT "Could not rescan serio: out of memory\n");
 		return;
+	}
 
 	event->type = SERIO_RESCAN;
 	event->serio = serio;
Signature · 2 lines
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]