Skip to contentSkip to conversation

disallow modular BINFMT_ELF

PATCH In review Adrian Bunk 6 participants 7 messages Nov 15, 2003 – Nov 17, 2003

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 disallow modular BINFMT_ELF

modular BINFMT_ELF gives unresolved symbols in 2.4 .

modular BINFMT_ELF gives the following unresolved symbols in 2.6:

<-- snip -->

WARNING: /lib/modules/2.6.0-test9-mm3/kernel/fs/binfmt_elf.ko needs unknown symbol __kernel_vsyscall
WARNING: /lib/modules/2.6.0-test9-mm3/kernel/fs/binfmt_elf.ko needs unknown symbol empty_zero_page
WARNING: /lib/modules/2.6.0-test9-mm3/kernel/fs/binfmt_elf.ko needs unknown symbol dump_task_fpu
WARNING: /lib/modules/2.6.0-test9-mm3/kernel/fs/binfmt_elf.ko needs unknown symbol dump_task_extended_fpu
WARNING: /lib/modules/2.6.0-test9-mm3/kernel/fs/binfmt_elf.ko needs unknown symbol dump_task_regs

<-- snip -->

Since modular BINFMT_ELF is pretty pathological I'd suggest the following patch:

fs/Kconfig.binfmt renamed from fs/Kconfig.binfmt.old +1 -1
@@ -1,5 +1,5 @@
 config BINFMT_ELF
-	tristate "Kernel support for ELF binaries"
+	bool "Kernel support for ELF binaries"
 	depends on MMU
 	default y
 	---help---

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#1 lore raw
Quoted 3 lines · Adrian Bunk

modular BINFMT_ELF gives unresolved symbols in 2.4 .

modular BINFMT_ELF gives the following unresolved symbols in 2.6:

Interesting. this causes me to wonder if we should bother making BINFMT_ELF an option at all...

Jeff

#2 lore raw
Quoted 8 lines · Jeff Garzik
Quoted 3 lines · Adrian Bunk

modular BINFMT_ELF gives unresolved symbols in 2.4 .

modular BINFMT_ELF gives the following unresolved symbols in 2.6:

Interesting. this causes me to wonder if we should bother making
BINFMT_ELF an option at all...

I strikes me as something that everyone is going to say yes to. If someone really doesn't want ELF then they are probably smart enough to change the Config script.

mh

Signature · 1 line
Martin Hicks || [email protected] || PGP/GnuPG: 0x4C7F2BEE
#3 lore raw
In reply to Jeff Garzik
Quoted 8 lines · Jeff Garzik
Quoted 2 lines · Adrian Bunk

modular BINFMT_ELF gives unresolved symbols in 2.4 . modular BINFMT_ELF gives the following unresolved symbols in 2.6:

Interesting. this causes me to wonder if we should bother making BINFMT_ELF an

option at all...

We have platforms uClinux for which ELF is not the preferred format so we should at least be able to compile it out.

Eric

#4 lore raw
Quoted 7 lines · Eric W. Biederman
Quoted 5 lines · Jeff Garzik
Quoted 2 lines · Adrian Bunk

modular BINFMT_ELF gives unresolved symbols in 2.4 . modular BINFMT_ELF gives the following unresolved symbols in 2.6:

Quoted 6 lines
Quoted 3 lines

Interesting. this causes me to wonder if we should bother making BINFMT_ELF an

option at all...

We have platforms uClinux for which ELF is not the preferred format so we should at least be able to compile it out.

Similarly on bi-arch supporting platforms, CONFIG_BINFMT_ELF controls 64-bit ELF support which one might want to disable and only use CONFIG_BINFMT_ELF32 (or other config option which controls 32-bit ELF support).

Jakub

#5 lore raw
In reply to Jeff Garzik
Quoted 8 lines · Jeff Garzik
Quoted 3 lines · Adrian Bunk

modular BINFMT_ELF gives unresolved symbols in 2.4 .

modular BINFMT_ELF gives the following unresolved symbols in 2.6:

Interesting. this causes me to wonder if we should bother making
BINFMT_ELF an option at all...

Many nommu targets don't support ELF binaries at all.

#6 lore raw
In reply to Jeff Garzik
Quoted 8 lines · Jeff Garzik
Quoted 3 lines · Adrian Bunk

modular BINFMT_ELF gives unresolved symbols in 2.4 .

modular BINFMT_ELF gives the following unresolved symbols in 2.6:

Interesting. this causes me to wonder if we should bother making
BINFMT_ELF an option at all...

And in addition to my previous post there's probably peopel who want only 32bit elf support on 64bit arches like paris64 and sparc64.