Skip to contentSkip to conversation

i2c-amd8111 bug fix (compare i2c-nforce2 bug fix)

PATCH New Hans-Frieder Vogt 2 participants 2 messages May 19, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i2c-amd8111 bug fix (compare i2c-nforce2 bug fix)

Hi,

a similar bug for the send/receive byte SMBus transfer as in the i2c-nforce2 bus driver is also present in the i2c-amd8111 driver. The attached small patch corrects it. I have no board with AMD-8111 and therefore cannot test it, but the patch brings the AMD-8111 bus driver in line with the ACPI 2.0 spec chapter 13.9, to which is is compliant according to the AMD-8111 data sheet (AMD document #24674). Can anybody with an AMD-8000 chip set based mainboard confirm the fix?

Hans-Frieder

--- lm_sensors2.orig/kernel/busses/i2c-amd8111.c 2003-08-03
18:09:00.000000000 +0200
+++ lm_sensors2/kernel/busses/i2c-amd8111.c 2003-11-30 15:45:42.000000000
+0100
@@ -198,7 +198,7 @@

case I2C_SMBUS_BYTE:
if (read_write = I2C_SMBUS_WRITE)
- amd_ec_write(smbus, AMD_SMB_DATA, data->byte);
+ amd_ec_write(smbus, AMD_SMB_CMD, command);
protocol |= AMD_SMB_PRTCL_BYTE;
break;

Signature · 2 lines
--
Hans-Frieder Vogt                 e-mail: [email protected]
#1 lore raw

PATCH 1/1 i2c-amd8111 bug fix (compare i2c-nforce2 bug fix)

Quoted 7 lines

a similar bug for the send/receive byte SMBus transfer as in the i2c-nforce2 bus driver is also present in the i2c-amd8111 driver. The attached small patch corrects it. I have no board with AMD-8111 and therefore cannot test it, but the patch brings the AMD-8111 bus driver in line with the ACPI 2.0 spec chapter 13.9, to which is is compliant according to the AMD-8111 data sheet (AMD document #24674). Can anybody with an AMD-8000 chip set based mainboard confirm the fix?

Not sure any of us does. You could try sending your patch to Vojtech Pavlik (vojtech at suse dot cz). Since he is the original driver author and sent various patches for it since, I'd guess he has the hardware to test it.

Thanks for the patch, will apply (unless Pavlik isn't happy with it).

Signature · 2 lines
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/