Skip to contentSkip to conversation

i2c bus drivers (2/4)

PATCH New Jean Delvare 2 participants 2 messages May 19, 2005

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i2c bus drivers (2/4)

This patch fixes i2c_smbus_write_byte() being broken for i2c-nforce2. This causes trouble when that module is used together with eeprom (which is also in 2.6). We have had three user reports about the problem.

Credits go to Mark D. Studebaker for finding and fixing the problem. We have also been contacting the module author (Hans-Frieder Vogt) but had no answer so far.

This is a serious bug fix, and I believe you shouldn't wait too long before applying it.

drivers/i2c/busses/i2c-nforce2.c renamed from drivers/i2c/busses/i2c-nforce2.c.orig +1 -1
@@ -147,7 +147,7 @@
 
 		case I2C_SMBUS_BYTE:
 			if (read_write = I2C_SMBUS_WRITE)
-				outb_p(data->byte, NVIDIA_SMB_DATA);
+				outb_p(command, NVIDIA_SMB_CMD);
 			protocol |= NVIDIA_SMB_PRTCL_BYTE;
 			break;
 
Signature · 2 lines
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/
Applied
#1 lore raw

PATCH 1/1 i2c bus drivers (2/4)

Quoted 10 lines · Jean Delvare

This patch fixes i2c_smbus_write_byte() being broken for i2c-nforce2. This causes trouble when that module is used together with eeprom (which is also in 2.6). We have had three user reports about the problem.

Credits go to Mark D. Studebaker for finding and fixing the problem. We have also been contacting the module author (Hans-Frieder Vogt) but had no answer so far.

This is a serious bug fix, and I believe you shouldn't wait too long before applying it.

Applied. And yes, I agree, I'll send it to Linus soon.

thanks,

greg k-h