Fix booting on a number of Motorola PPC32 machines
PATCH 1/1 Fix booting on a number of Motorola PPC32 machines
Hello. Currently a number of Motorola PPC32 machine will not boot, as the final zImage isn't built correctly for them. The problem is that we end up setting a Makefile variable to ' y' instead of 'y'. After talking with Sam Ravnborg, the following is acceptable.
===== arch/ppc/boot/simple/Makefile 1.23 vs edited =====
arch/ppc/boot/simple/Makefile +2 -3
@@ -73,9 +73,8 @@ cacheflag-$(CONFIG_K2) := -include $(clear_L2_L3) # kconfig 'feature', only one of these will ever be 'y' at a time. -# The rest will be unset. -motorola := $(CONFIG_MCPN765)$(CONFIG_MVME5100)$(CONFIG_PRPMC750) \ -$(CONFIG_PRPMC800)$(CONFIG_LOPEC)$(CONFIG_PPLUS) +# The rest will be unset. Each of these must be on one line. +motorola := $(CONFIG_MCPN765)$(CONFIG_MVME5100)$(CONFIG_PRPMC750)$(CONFIG_PRPMC800)$(CONFIG_LOPEC)$(CONFIG_PPLUS) pcore := $(CONFIG_PCORE)$(CONFIG_POWERPMC250) zimage-$(motorola) := zImage-PPLUS
Signature · 2 lines
Tom Rini http://gate.crashing.org/~trini/
PATCH RESEND 1/1 Fix booting on a number of Motorola PPC32 machines
Hello. I first sent this on 3 Dec 2003, with no response or followup. Currently a number of Motorola PPC32 machine will not boot, as the final zImage isn't built correctly for them. The problem is that we end up setting a Makefile variable to ' y' instead of 'y'. After talking with Sam Ravnborg, the following is acceptable.
===== arch/ppc/boot/simple/Makefile 1.23 vs edited =====
arch/ppc/boot/simple/Makefile +2 -3
@@ -73,9 +73,8 @@ cacheflag-$(CONFIG_K2) := -include $(clear_L2_L3) # kconfig 'feature', only one of these will ever be 'y' at a time. -# The rest will be unset. -motorola := $(CONFIG_MCPN765)$(CONFIG_MVME5100)$(CONFIG_PRPMC750) \ -$(CONFIG_PRPMC800)$(CONFIG_LOPEC)$(CONFIG_PPLUS) +# The rest will be unset. Each of these must be on one line. +motorola := $(CONFIG_MCPN765)$(CONFIG_MVME5100)$(CONFIG_PRPMC750)$(CONFIG_PRPMC800)$(CONFIG_LOPEC)$(CONFIG_PPLUS) pcore := $(CONFIG_PCORE)$(CONFIG_POWERPMC250) zimage-$(motorola) := zImage-PPLUS
Signature · 2 lines
Tom Rini http://gate.crashing.org/~trini/
PATCH RESEND 1/1 Fix booting on a number of Motorola PPC32 machines
In reply to Tom RiniHello. I first sent this on 3 Dec 2003, and again on 8 Dec 2003, with no response or followup.
Currently a number of Motorola PPC32 machine will not boot, as the final zImage isn't built correctly for them. The problem is that we end up setting a Makefile variable to ' y' instead of 'y'. After talking with Sam Ravnborg, the following is acceptable.
===== arch/ppc/boot/simple/Makefile 1.23 vs edited =====
arch/ppc/boot/simple/Makefile +2 -3
@@ -73,9 +73,8 @@ cacheflag-$(CONFIG_K2) := -include $(clear_L2_L3) # kconfig 'feature', only one of these will ever be 'y' at a time. -# The rest will be unset. -motorola := $(CONFIG_MCPN765)$(CONFIG_MVME5100)$(CONFIG_PRPMC750) \ -$(CONFIG_PRPMC800)$(CONFIG_LOPEC)$(CONFIG_PPLUS) +# The rest will be unset. Each of these must be on one line. +motorola := $(CONFIG_MCPN765)$(CONFIG_MVME5100)$(CONFIG_PRPMC750)$(CONFIG_PRPMC800)$(CONFIG_LOPEC)$(CONFIG_PPLUS) pcore := $(CONFIG_PCORE)$(CONFIG_POWERPMC250) zimage-$(motorola) := zImage-PPLUS
Signature · 2 lines
Tom Rini http://gate.crashing.org/~trini/
arch/ppc/boot/simple/Makefile line 78
Quoted 13 lines · Tom Rini
=====
arch/ppc/boot/simple/Makefile1.23 vs edited =====arch/ppc/boot/simple/Makefile +2
-3@@ -73,9 +73,8 @@ cacheflag-$(CONFIG_K2) := -include $(clear_L2_L3) # kconfig 'feature', only one of these will ever be 'y' at a time. -# The rest will be unset. -motorola := $(CONFIG_MCPN765)$(CONFIG_MVME5100)$(CONFIG_PRPMC750) \ -$(CONFIG_PRPMC800)$(CONFIG_LOPEC)$(CONFIG_PPLUS) +# The rest will be unset. Each of these must be on one line. +motorola := $(CONFIG_MCPN765)$(CONFIG_MVME5100)$(CONFIG_PRPMC750)$(CONFIG_PRPMC800)$(CONFIG_LOPEC)$(CONFIG_PPLUS) pcore := $(CONFIG_PCORE)$(CONFIG_POWERPMC250)
If you want to keep the original line for readability, follow it with
motorola := $(strip $(motorola))
To remove leading and trailing spaces.