Skip to contentSkip to conversation

IrDA kernel log buster

PATCH In review Jean Tourrilhes 2 participants 2 messages Dec 11, 2003 – Dec 13, 2003 Networking

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 IrDA kernel log buster

Hi Marcelo,

I just ran 2.4.23, and after a few min the disk reached 100%
capacity. A quick check lead to to oversized kernel log, and to the following changeset :

http://linux.bkbits.net:8080/linux-2.4/[email protected]?nav=index.html|ChangeSet@-12w

Patch to fix this problem is attached below, I've just
backported the proper fixes from 2.5.X into 2.4.X.
Probably this person did too much Python, but in C you need
braces around multiple statements part of the same branch, so the second printf was always executed even when logging was disabled. I also don't understand why this person didn't decided to backport the 2.5.X fix.
I'm also bit surprised that this kind of patch went into the
kernel behind my back, because I though that freeze meant not accepting untested patch from random hacker.

	Have fun...

	Jean

-------------------------------------------------

net/irda/irnet/irnet.h renamed from net/irda/irnet/irnet.j1.h +10 -10
diff -u -p linux/net/irda/irnet/irnet.j1.h linux/net/irda/irnet/irnet.h
@@ -322,29 +322,29 @@
  * compiler will optimise away the if() in all cases.
  */
 /* All error messages (will show up in the normal logs) */
-#define DERROR(dbg, args...) \
+#define DERROR(dbg, format, args...) \
 	{if(DEBUG_##dbg) \
-		printk(KERN_INFO "irnet: %s(): ", __FUNCTION__); printk(args);}
+		printk(KERN_INFO "irnet: %s(): " format, __FUNCTION__ , ##args);}
 
 /* Normal debug message (will show up in /var/log/debug) */
-#define DEBUG(dbg, args...) \
+#define DEBUG(dbg, format, args...) \
 	{if(DEBUG_##dbg) \
-		printk(KERN_DEBUG "irnet: %s(): ", __FUNCTION__); printk(args);}
+		printk(KERN_DEBUG "irnet: %s(): " format, __FUNCTION__ , ##args);}
 
 /* Entering a function (trace) */
-#define DENTER(dbg, args...) \
+#define DENTER(dbg, format, args...) \
 	{if(DEBUG_##dbg) \
-	printk(KERN_DEBUG "irnet: ->%s", __FUNCTION__); printk(args);}
+		printk(KERN_DEBUG "irnet: -> %s" format, __FUNCTION__ , ##args);}
 
 /* Entering and exiting a function in one go (trace) */
-#define DPASS(dbg, args...) \
+#define DPASS(dbg, format, args...) \
 	{if(DEBUG_##dbg) \
-		printk(KERN_DEBUG "irnet: <>%s", __FUNCTION__); printk(args);}
+		printk(KERN_DEBUG "irnet: <>%s" format, __FUNCTION__ , ##args);}
 
 /* Exiting a function (trace) */
-#define DEXIT(dbg, args...) \
+#define DEXIT(dbg, format, args...) \
 	{if(DEBUG_##dbg) \
-		printk(KERN_DEBUG "irnet: <-%s()", __FUNCTION__); printk(args);}
+		printk(KERN_DEBUG "irnet: <-%s()" format, __FUNCTION__ , ##args);}
 
 /* Exit a function with debug */
 #define DRETURN(ret, dbg, args...) \
#1 lore raw
Quoted 8 lines · Jean Tourrilhes

Hi Marcelo,

I just ran 2.4.23, and after a few min the disk reached 100%
capacity. A quick check lead to to oversized kernel log, and to the following changeset :

http://linux.bkbits.net:8080/linux-2.4/[email protected]?nav=index.html|ChangeSet@-12w

Quoted 10 lines

Patch to fix this problem is attached below, I've just
backported the proper fixes from 2.5.X into 2.4.X.
Probably this person did too much Python, but in C you need
braces around multiple statements part of the same branch, so the second printf was always executed even when logging was disabled. I also don't understand why this person didn't decided to backport the 2.5.X fix.
I'm also bit surprised that this kind of patch went into the
kernel behind my back, because I though that freeze meant not accepting untested patch from random hacker.

Indeed accepting the patch was a mistake.

Fix applied.