Skip to contentSkip to conversation

Patches

PATCH New Robert Schwebel 3 participants 5 messages Dec 15, 2003

lore
Share & tools
lore
#0 lore raw

cover Patches

Hi,

here are some of the patches from our -ptx tree. Please review as I'm not sure any more which ones I've already sent to the list. Patches are against CVS as of this morning.

Robert

Signature · 5 lines
 Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
     Hornemannstra?e 12,  31137 Hildesheim, Germany
    Phone: +49-5121-28619-0 |  Fax: +49-5121-28619-4
#1 lore raw

cover Patches

Dear Robert,

Quoted 4 lines · in message <[email protected]> Robert Schwebel wrote:

here are some of the patches from our -ptx tree. Please review as I'm not sure any more which ones I've already sent to the list. Patches are against CVS as of this morning.

Arghhh...

You are not sure what you did? What makes you think we know better than you yourself what you are doing????

Sorry, but it doesn't work this way.

I will certainly NOT review your old patches and compare against the new ones which might bee needed ond what has been obsoleted. Either YOU state that the old patches, as far they have not been mergend yet, are crap and shall be ignored, or YOU will please send _incremental_ patches against a version with your old patches added.

Please decide what you want, but don't send several versions of the same stuff without making clear what to use and what to throw away.

Best regards,

Wolfgang Denk

Signature · 4 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
"Just think, with VLSI we can have 100 ENIACS on a chip!"
- Alan Perlis
#2 lore raw

cover Patches

Quoted 2 lines · Wolfgang Denk

I will certainly NOT review your old patches and compare against the new ones which might bee needed ond what has been obsoleted.

The patches are against current CVS - I have no idea what you mean here. I tried to send the patches some days ago but got some strange error messages from sourceforge due to an incorrect From: header, so I don't know if they made it to the list in a proper way. In case you got them they are identical to the ones here.

Some of the stuff here was sent to you ages ago without being merged; all I would like to ask you is to have a look at it and say if you have further complains I have to work on.

Quoted 3 lines

Either YOU state that the old patches, as far they have not been mergend yet, are crap and shall be ignored, or YOU will please send _incremental_ patches against a version with your old patches added.

If I had stated that they are crap I hadn't sent them. The patches are orthogonal, they have specific documentation at the begining of the patch file and they are reviewed for not having trailing whitespace.

Robert

Signature · 5 lines
 Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
     Hornemannstra?e 12,  31137 Hildesheim, Germany
    Phone: +49-5121-28619-0 |  Fax: +49-5121-28619-4
#3 lore raw

cover Patches

Quoted 2 lines · In message <[email protected]> Robert Schwebel wrote:

The patches are against current CVS - I have no idea what you mean here.

You wrote: "Please review as I'm not sure any more which ones I've already sent to the list".

Quoted 5 lines

I tried to send the patches some days ago but got some strange error messages from sourceforge due to an incorrect From: header, so I don't know if they made it to the list in a proper way. In case you got them

Some of the stuff here was sent to you ages ago without being merged;

And you know exactly why. We discussed this at length before.

Quoted 7 lines
Quoted 3 lines

Either YOU state that the old patches, as far they have not been mergend yet, are crap and shall be ignored, or YOU will please send _incremental_ patches against a version with your old patches added.

If I had stated that they are crap I hadn't sent them. The patches are orthogonal, they have specific documentation at the begining of the patch file and they are reviewed for not having trailing whitespace.

To make this clear: you want me to ignore all the patches you sent on Dec 09, and use the ones you sent today. Is this correct?

I'm sorry if this sounds like a stupid question, but your message sounded as if they might be different, and you want me to figure out which is good and which not, or which parts to use and which to throw away.

Best regards,

Wolfgang Denk

Signature · 3 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
Sorry, but my karma just ran over your dogma.
#4 lore raw

cover Patches

Quoted 2 lines · Wolfgang Denk

You wrote: "Please review as I'm not sure any more which ones I've already sent to the list".

... back half a year ago. It may be that you have changed your oppinion regarding one or the other topic. If not just say "reject" and I'm happy.

Quoted 2 lines

To make this clear: you want me to ignore all the patches you sent on Dec 09, and use the ones you sent today. Is this correct?

This lets me assume that they indeed _made_ it to the list; in this case ignore one of the posts - the patches are identical, the versions from today have been re-applied against today's CVS.

Quoted 4 lines

I'm sorry if this sounds like a stupid question, but your message sounded as if they might be different, and you want me to figure out which is good and which not, or which parts to use and which to throw away.

No.

Robert

Signature · 5 lines
 Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
     Hornemannstra?e 12,  31137 Hildesheim, Germany
    Phone: +49-5121-28619-0 |  Fax: +49-5121-28619-4