Skip to contentSkip to conversation

fix a compile warning in amd76x_pm.c (fwd)

PATCH New Adrian Bunk 1 participant 1 message Dec 19, 2003 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix a compile warning in amd76x_pm.c (fwd)

Hi Marcelo,

the patch forwarded below still applies and compiles against 2.4.24-pre1.

Please apply
Adrian

----- Forwarded message from Adrian Bunk <[email protected]> -----

Date: Sun, 3 Aug 2003 12:58:08 +0200
From: Adrian Bunk <[email protected]>
To: Marcelo Tosatti <[email protected]>,
Johnathan Hicks <[email protected]>
Cc: [email protected], [email protected]
Subject: [2.4 patch] fix a compile warning in amd76x_pm.c

I got the following compile warning in 2.4.22-pre10:

<-- snip -->

...
gcc -D__KERNEL__ -I/home/bunk/linux/kernel-2.4/linux-2.4.22-pre10-full/include - Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing
-fno-common -pipe -mpreferred-stack-boundary=2 -march=k6 -nostdinc -iwithprefix
include -DKBUILD_BASENAME=amd76x_pm -c -o amd76x_pm.o amd76x_pm.c amd76x_pm.c:483: warning: `activate_amd76x_SLP' defined but not used
...

<-- snip -->

The following patch puts this function under the same #ifdef as it's only caller:

drivers/char/amd76x_pm.c renamed from drivers/char/amd76x_pm.c.old +1 -3
@@ -474,7 +474,7 @@
 }
 #endif
 
-
+#ifdef AMD76X_POS
 /*
  * Activate sleep state via its ACPI register (PM1_CNT).
  */
@@ -489,8 +489,6 @@
 	outw(regshort, amd76x_pm_cfg.slp_reg);
 }
 
-
-#ifdef AMD76X_POS
 /*
  * Wrapper function to activate POS sleep state.
  */

I've tested the compilation with 2.4.22-pre10.

Please apply
Adrian

Signature · 12 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

----- End forwarded message -----