Skip to contentSkip to conversation

ext2 (auto)fsck

PATCH New Richard Zidlicky 1 participant 1 message Dec 21, 2003 Kernel automounter

lore
Share & tools
lore

Richard Zidlicky

author
#0 lore raw

PATCH 1/1 ext2 (auto)fsck

Hi,

I came across this, doesnt look like the intended behaviour:

modules/mount_ext2.c renamed from modules/mount_ext2.c.rz +1 -1
@@ -58,7 +58,7 @@
 
   syslog(LOG_DEBUG, MODPREFIX "calling fsck.ext2 -p %s", what);
   err = spawnl(LOG_DEBUG, PATH_E2FSCK, PATH_E2FSCK, "-p", what, NULL);
-  if ( err & ~7 ) {
+  if ( err & 7 ) {
     syslog(LOG_ERR, MODPREFIX "%s: filesystem needs repair, won't mount",
 	   what);
     return 1;

Actually it may be better to simply err out on any fsck error and not try to interpret e2fsck error codes?

Richard