Skip to contentSkip to conversation

2.6.0-mm1

DISCUSSION Pascal Schmidt 2 participants 4 messages Dec 23, 2003 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

On Tue, 23 Dec 2003 06:20:14 +0100, you wrote in linux.kernel:

Review

Quoted 8 lines
(quoted diff) +2 -0
+atapi-mo-support.patch
 
 Fix support for ATAPI MO drives (needs updating to reflect the changes in
 mt-ranier-support.patch).
 
+mt-ranier-support.patch
 
 Mt Ranier support in the CDROM uniform layer.

Since the atapi-mo patch is mine, is there something I need to do?

Signature · 2 lines
Ciao,
Pascal
#2 lore raw
Quoted 4 lines · Pascal Schmidt

On Tue, 23 Dec 2003 06:20:14 +0100, you wrote in linux.kernel:

Quoted 2 lines

+atapi-mo-support.patch

Quoted 8 lines
Quoted 6 lines

Fix support for ATAPI MO drives (needs updating to reflect the changes in mt-ranier-support.patch).

+mt-ranier-support.patch

Mt Ranier support in the CDROM uniform layer.

Since the atapi-mo patch is mine, is there something I need to do?

Nah don't worry about it, Andrew and I just agreed that I'd merge the remaining changes once 2.6.0-mm1 was up. Basically, MO needs to set _RAM capability so we can kill the various MO checks.

Jens

#3 lore raw
Quoted 4 lines · Jens Axboe
Quoted 1 line

Since the atapi-mo patch is mine, is there something I need to do?

Nah don't worry about it, Andrew and I just agreed that I'd merge the remaining changes once 2.6.0-mm1 was up. Basically, MO needs to set _RAM capability so we can kill the various MO checks.

Please remember that you can't send the MO drive any DVD-RAM specific commands and expect it to work. The special-casing in the probe routine in ide-cd is there for a reason, and I don't think calling cdrom_dvdram_open_write would be a good idea, either. I haven't actually looked at that routine, but if it sends anything to the drive, my MO drive won't like it one bit. It will at best error out and then cdrom_dvdram_open_write will error out, too, disallowing opening for write, right?

Signature · 2 lines
Ciao,
Pascal
#4 lore raw
Quoted 7 lines · Pascal Schmidt
Quoted 4 lines · Jens Axboe
Quoted 1 line

Since the atapi-mo patch is mine, is there something I need to do?

Nah don't worry about it, Andrew and I just agreed that I'd merge the remaining changes once 2.6.0-mm1 was up. Basically, MO needs to set _RAM capability so we can kill the various MO checks.

Quoted 8 lines

Please remember that you can't send the MO drive any DVD-RAM specific commands and expect it to work. The special-casing in the probe routine in ide-cd is there for a reason, and I don't think calling cdrom_dvdram_open_write would be a good idea, either. I haven't actually looked at that routine, but if it sends anything to the drive, my MO drive won't like it one bit. It will at best error out and then cdrom_dvdram_open_write will error out, too, disallowing opening for write, right?

The changes are nothing like that. Don't confuse CDC_DVD_RAM and CDC_RAM
- the latter just means that it is ok to open this media for random writes so we don't have to check for three types of different devices.

Signature · 1 line
Jens Axboe