Skip to contentSkip to conversation

Fix SCx200 dependancies

PATCH New Jean Delvare 2 participants 2 messages May 19, 2005 I2C subsystem host drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix SCx200 dependancies

Hi Greg,

The following patch fixes incorrect dependencies (as far as I can see) for the SCx200 modules. A similar patch (with even more fixes) is also needed for Linux 2.4, and will be part of my next wave to Marcelo. Note that I don't have the necessary hardware to actually test anything, but a quick look at the code doesn't leave much place for doubt IMHO. Comments welcome.

drivers/i2c/busses/Kconfig renamed from drivers/i2c/busses/Kconfig.orig +2 -2
@@ -201,7 +201,7 @@
 
 config SCx200_I2C
 	tristate "NatSemi SCx200 I2C using GPIO pins"
-	depends on SCx200 && I2C_ALGOBIT
+	depends on SCx200_GPIO && I2C_ALGOBIT
 	help
 	  Enable the use of two GPIO pins of a SCx200 processor as an I2C bus.
 
@@ -228,7 +228,7 @@
 
 config SCx200_ACB
 	tristate "NatSemi SCx200 ACCESS.bus"
-	depends on I2C_ALGOBIT!=n && I2C
+	depends on I2C
 	help
 	  Enable the use of the ACCESS.bus controllers of a SCx200 processor.
 
Signature · 2 lines
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/
Applied
#1 lore raw

PATCH 1/1 Fix SCx200 dependancies

Quoted 8 lines · Jean Delvare

Hi Greg,

The following patch fixes incorrect dependencies (as far as I can see) for the SCx200 modules. A similar patch (with even more fixes) is also needed for Linux 2.4, and will be part of my next wave to Marcelo. Note that I don't have the necessary hardware to actually test anything, but a quick look at the code doesn't leave much place for doubt IMHO. Comments welcome.

Applied, thanks.

greg k-h