kgdb cleanups
Hi!
Main documentation of kgdb has >50% of changelog. That's bad, because real doc is hidden in second half of file. [I actually moved it into Doc*/i386/kgdb/ChangeLog, but I'm not sure if its worth it; its not in this patch.] Unused dwarf2 support killed. TRAP_BAD_SYSCALL_EXITS support can not be activated, anyway, AFAICS; killed. Killed 'tell-indent-to' magic markers, they confuse my eyes. Attempted to document malloc(). Functions that can be static now *are* static. There are two horrible pieces of code I did not dare to kill, yet. First is "get_char" (it just dereferences pointer!), second is memcmp() variant. Killed ascii-art, SHOOTING documentation of hexToInt.
Tell me if this ooks like way to go...
Pavel
Documentation/i386/kgdb/kgdb.txt renamed from linux/Documentation/i386/kgdb/kgdb.txt +4 -237
@@ -1,242 +1,9 @@ -Last edit: <20030806.1637.12> -This file has information specific to the i386 kgdb option. Other -platforms with the kgdb option may behave in a similar fashion. - -New features: -============ -20030806.1557.37 -This version was made against the 2.6.0-test2 kernel. We have made the -following changes: - -- The getthread() code in the stub calls find_task_by_pid(). It fails - if we are early in the bring up such that the pid arrays have yet to - be allocated. We have added a line to kernel/pid.c to make - "kgdb_pid_init_done" true once the arrays are allocated. This way the - getthread() code knows not to call. This is only used by the thread - debugging stuff and threads will not yet exist at this point in the - boot. - -- For some reason, gdb was not asking for a new thread list when the - "info thread" command was given. We changed to the newer version of - the thread info command and gdb now seems to ask when needed. Result, - we now get all threads in the thread list. - -- We now respond to the ThreadExtraInfo request from gdb with the thread - name from task_struct .comm. This then appears in the thread list. - Thoughts on additional options for this are welcome. Things such as - "has BKL" and "Preempted" come to mind. I think we could have a flag - word that could enable different bits of info here. - -- We now honor, sort of, the C and S commands. These are continue and - single set after delivering a signal. We ignore the signal and do the - requested action. This only happens when we told gdb that a signal - was the reason for entry, which is only done on memory faults. The - result is that you can now continue into the Oops. - -- We changed the -g to -gdwarf-2. This seems to be the same as -ggdb, - but it is more exact on what language to use. - -- We added two dwarf2 include files and a bit of code at the end of - entry.S. This does not yet work, so it is disabled. Still we want to - keep track of the code and "maybe" someone out there can fix it. - -- Randy Dunlap sent some fix ups for this file which are now merged. - -- Hugh Dickins sent a fix to a bit of code in traps.c that prevents a - compiler warning if CONFIG_KGDB is off (now who would do that :). - -- Andrew Morton sent a fix for the serial driver which is now merged. - -- Andrew also sent a change to the stub around the cpu managment code - which is also merged. - -- Andrew also sent a patch to make "f" as well as "g" work as SysRq - commands to enter kgdb, merged. - -- If CONFIG_KGDB and CONFIG_DEBUG_SPINLOCKS are both set we added a - "who" field to the spinlock data struct. This is filled with - "current" when ever the spinlock suceeds. Useful if you want to know - who has the lock. - -_ And last, but not least, we fixed the "get_cu" macro to properly get - the current value of "current". - -New features: -============ -20030505.1827.27 -We are starting to align with the sourceforge version, at least in -commands. To this end, the boot command string to start kgdb at -boot time has been changed from "kgdb" to "gdb". - -Andrew Morton sent a couple of patches which are now included as follows: -1.) We now return a flag to the interrupt handler. -2.) We no longer use smp_num_cpus (a conflict with the lock meter). -3.) And from William Lee Irwin III <[email protected]> code to make - sure high-mem is set up before we attempt to register our interrupt - handler. -We now include asm/kgdb.h from config.h so you will most likely never -have to include it. It also 'NULLS' the kgdb macros you might have in -your code when CONFIG_KGDB is not defined. This allows you to just -turn off CONFIG_KGDB to turn off all the kgdb_ts() calls and such. -This include is conditioned on the machine being an x86 so as to not -mess with other archs. - -20020801.1129.03 -This is currently the version for the 2.4.18 (and beyond?) kernel. - -We have several new "features" beginning with this version: - -1.) Kgdb now syncs the "other" CPUs with a cross-CPU NMI. No more - waiting and it will pull that guy out of an IRQ off spin lock :) - -2.) We doctored up the code that tells where a task is waiting and - included it so that the "info thread" command will show a bit more - than "schedule()". Try it... - -3.) Added the ability to call a function from gdb. All the standard gdb - issues apply, i.e. if you hit a breakpoint in the function, you are - not allowed to call another (gdb limitation, not kgdb). To help - this capability we added a memory allocation function. Gdb does not - return this memory (it is used for strings that you pass to that function - you are calling from gdb) so we fixed up a way to allow you to - manually return the memory (see below). - -4.) Kgdb time stamps (kgdb_ts()) are enhanced to expand what was the - interrupt flag to now also include the preemption count and the - "in_interrupt" info. The flag is now called "with_pif" to indicate - the order, preempt_count, in_interrupt, flag. The preempt_count is - shifted left by 4 bits so you can read the count in hex by dropping - the low order digit. In_interrupt is in bit 1, and the flag is in - bit 0. - -5.) The command: "p kgdb_info" is now expanded and prints something - like: -(gdb) p kgdb_info -$2 = {used_malloc = 0, called_from = 0xc0107506, entry_tsc = 67468627259, - errcode = 0, vector = 3, print_debug_info = 0, hold_on_sstep = 1, - cpus_waiting = {{task = 0xc027a000, pid = 32768, hold = 0, - regs = 0xc027bf84}, {task = 0x0, pid = 0, hold = 0, regs = 0x0}}} - - Things to note here: a.) used_malloc is the amount of memory that - has been malloc'ed to do calls from gdb. You can reclaim this - memory like this: "p kgdb_info.used_malloc=0" Cool, huh? b.) - cpus_waiting is now "sized" by the number of CPUs you enter at - configure time in the kgdb configure section. This is NOT used - anywhere else in the system, but it is "nice" here. c.) The task's - "pid" is now in the structure. This is the pid you will need to use - to decode to the thread id to get gdb to look at that thread. - Remember that the "info thread" command prints a list of threads - wherein it numbers each thread with its reference number followed - by the thread's pid. Note that the per-CPU idle threads actually - have pids of 0 (yes, there is more than one pid 0 in an SMP system). - To avoid confusion, kgdb numbers these threads with numbers beyond - the MAX_PID. That is why you see 32768 and above. - -6.) A subtle change, we now provide the complete register set for tasks - that are active on the other CPUs. This allows better trace back on - those tasks. - - And, let's mention what we could not fix. Back-trace from all but the - thread that we trapped will, most likely, have a bogus entry in it. - The problem is that gdb does not recognize the entry code for - functions that use "current" near (at all?) the entry. The compiler - is putting the "current" decode as the first two instructions of the - function where gdb expects to find %ebp changing code. Back trace - also has trouble with interrupt frames. I am talking with Daniel - Jacobowitz about some way to fix this, but don't hold your breath. - -20011220.0050.35 -Major enhancement with this version is the ability to hold one or more -CPUs in an SMP system while allowing the others to continue. Also, by -default only the current CPU is enabled on single-step commands (please -note that gdb issues single-step commands at times other than when you -use the si command). - -Another change is to collect some useful information in -a global structure called "kgdb_info". You should be able to just: - -p kgdb_info - -although I have seen cases where the first time this is done gdb just -prints the first member but prints the whole structure if you then enter -CR (carriage return or enter). This also works: - -p *&kgdb_info - -Here is a sample: -(gdb) p kgdb_info -$4 = {called_from = 0xc010732c, entry_tsc = 32804123790856, errcode = 0, - vector = 3, print_debug_info = 0} - -"Called_from" is the return address from the current entry into kgdb. -Sometimes it is useful to know why you are in kgdb, for example, was -it an NMI or a real breakpoint? The simple way to interrogate this -return address is: - -l *0xc010732c - -which will print the surrounding few lines of source code. - -"Entry_tsc" is the CPU TSC on entry to kgdb (useful to compare to the -kgdb_ts entries). - -"errcode" and "vector" are other entry parameters which may be helpful on -some traps. - -"print_debug_info" is the internal debugging kgdb print enable flag. Yes, -you can modify it. - -In SMP systems kgdb_info also includes the "cpus_waiting" structure and -"hold_on_step": - -(gdb) p kgdb_info -$7 = {called_from = 0xc0112739, entry_tsc = 1034936624074, errcode = 0, - vector = 2, print_debug_info = 0, hold_on_sstep = 1, cpus_waiting = {{ - task = 0x0, hold = 0, regs = 0x0}, {task = 0xc71b8000, hold = 0, - regs = 0xc71b9f70}, {task = 0x0, hold = 0, regs = 0x0}, {task = 0x0, - hold = 0, regs = 0x0}, {task = 0x0, hold = 0, regs = 0x0}, {task = 0x0, - hold = 0, regs = 0x0}, {task = 0x0, hold = 0, regs = 0x0}, {task = 0x0, - hold = 0, regs = 0x0}}} - -"Cpus_waiting" has an entry for each CPU other than the current one that -has been stopped. Each entry contains the task_struct address for that -CPU, the address of the regs for that task and a hold flag. All these -have the proper typing so that, for example: - -p *kgdb_info.cpus_waiting[1].regs - -will print the registers for CPU 1. - -"Hold_on_sstep" is a new feature with this version and comes up set or -true. What this means is that whenever kgdb is asked to single-step all -other CPUs are held (i.e. not allowed to execute). The flag applies to -all but the current CPU and, again, can be changed: - -p kgdb_info.hold_on_sstep=0 - -restores the old behavior of letting all CPUs run during single-stepping. - -Likewise, each CPU has a "hold" flag, which if set, locks that CPU out -of execution. Note that this has some risk in cases where the CPUs need -to communicate with each other. If kgdb finds no CPU available on exit, -it will push a message thru gdb and stay in kgdb. Note that it is legal -to hold the current CPU as long as at least one CPU can execute. - -20010621.1117.09 -This version implements an event queue. Events are signaled by calling -a function in the kgdb stub and may be examined from gdb. See EVENTS -below for details. This version also tightens up the interrupt and SMP -handling to not allow interrupts on the way to kgdb from a breakpoint -trap. It is fine to allow these interrupts for user code, but not -system debugging. - Version ======= -This version of the kgdb package was developed and tested on -kernel version 2.4.16. It will not install on any earlier kernels. -It is possible that it will continue to work on later versions -of 2.4 and then versions of 2.5 (I hope). +This version of the kgdb package was developed and tested on kernel +version 2.6.0. It is possible that it will continue to work on later +versions of 2.6. Debugging Setup
@@ -314,7 +81,7 @@ set up after any serial drivers, it is possible that this command will work when the control-C will not. -Save and exit the Xconfig program. Then do "make clean" , "make dep" +Save and exit the Xconfig program. Then do "make clean" and "make bzImage" (or whatever target you want to make). This gets the kernel compiled with the "-g" option set -- necessary for debugging.
Documentation/i386/kgdb/kgdbeth.txt renamed from linux/Documentation/i386/kgdb/kgdbeth.txt +4 -4
@@ -33,8 +33,8 @@ gdbeth=DEVICENUM gdbeth_remoteip=HOSTIPADDR - gdbeth_remotemac=REMOTEMAC - gdbeth_localmac=LOCALMAC + gdbeth_remotemac=HOSTMAC + gdbeth_localmac=TARGETMAC kgdbeth=DEVICENUM sets the ethernet device number to listen on for debugging packets. e.g. kgdbeth=0 listens on eth0.
@@ -43,10 +43,10 @@ Only packets originating from this IP address will be accepted by the debugger. e.g. kgdbeth_remoteip=192.168.2.2 -kgdbeth_remotemac=REMOTEMAC sets the ethernet address of the HOST machine. +kgdbeth_remotemac=HOSTMAC sets the ethernet address of the HOST machine. e.g. kgdbeth_remotemac=00:07:70:12:4E:F5 -kgdbeth_localmac=LOCALMAC sets the ethernet address of the TARGET machine. +kgdbeth_localmac=TARGETMAC sets the ethernet address of the TARGET machine. e.g. kgdbeth_localmac=00:10:9F:18:21:3C You can also set the following command-line option on the TARGET kernel:
arch/i386/kernel/entry.S renamed from linux/arch/i386/kernel/entry.S +0 -58
70 lines not on this page · raw message
arch/i386/kernel/kgdb_stub.c renamed from linux/arch/i386/kernel/kgdb_stub.c +53 -116
440 lines not on this page · raw message
include/linux/dwarf2-lang.h renamed from linux/include/linux/dwarf2-lang.h +0 -132
132 lines not on this page · raw message
include/linux/dwarf2.h renamed from linux/include/linux/dwarf2.h +0 -738
738 lines not on this page · raw message
Signature · 2 lines
When do you have a heart between your knees? [Johanka's followup: and *two* hearts?]
Quoted 1 line
Unused dwarf2 support killed
George Anzinger mentioned to me a few days ago that he was finishing off the dwarf2 support and getting a new patch over to Andrew. Other than that, it looks OK.
Regards,
Robert.
Signature · 3 lines
Robert Walsh Amalgamated Durables, Inc. - "We don't make the things you buy." Email: [email protected]