s3 sleep: Kill obsolete debugging code
Hi!
wakeup.S includes some rather nasty, and unneccessary debugging code. (It used to try to flush caches/tlbs; now its totally useless). Please apply,
Pavel
arch/i386/kernel/acpi/wakeup.S +0 -8
@@ -193,11 +193,6 @@ # and restore the stack ... but you need gdt for this to work movl saved_context_esp, %esp - movw $0x0e00 + 'W', 0xb8018 - outl %eax, $0x80 - outl %eax, $0x80 - movw $0x0e00 + 'O', 0xb8018 - movl %cs:saved_magic, %eax cmpl $0x12345678, %eax jne bogus_magic
@@ -205,9 +200,6 @@ # jump to place where we left off movl saved_eip,%eax movw $0x0e00 + 'x', 0xb8018 - outl %eax, $0x80 - outl %eax, $0x80 - movw $0x0e00 + '!', 0xb801a jmp *%eax bogus_magic:
Signature · 2 lines
When do you have a heart between your knees? [Johanka's followup: and *two* hearts?]
In message <[email protected]> you write:
Quoted 6 lines
Hi!
wakeup.Sincludes some rather nasty, and unneccessary debugging code. (It used to try to flush caches/tlbs; now its totally useless). Please apply,
Pavel
Removing asm not really trivial unless the author sent it...
Sorry,
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
Hi!
Quoted 6 lines
Quoted 4 lines
wakeup.Sincludes some rather nasty, and unneccessary debugging code. (It used to try to flush caches/tlbs; now its totally useless). Please apply,
PavelRemoving asm not really trivial unless the author sent it...
I was author of original debugging code, than Patrick simplified it, and by now its totaly useless. Anyway it seems that Andrew took the patch, so it is on its way to linus.
Pavel
Signature · 2 lines
Horseback riding is like software... ...vgf orggre jura vgf serr.