Skip to contentSkip to conversation

do not leak memory in powernow-k8

PATCH Pavel Machek 1 participant 1 message Jan 3, 2004

lore
Share & tools
lore
#0 lore raw

Hi!

This prevents memory leak if something goes wrong. Please apply,

Pavel

arch/i386/kernel/cpu/cpufreq/powernow-k8.c +3 -1
Index: linux.new/arch/i386/kernel/cpu/cpufreq/powernow-k8.c
===================================================================
@@ -687,11 +687,13 @@
 			if (ppst[j].vid < rvo) {	/* vid+rvo >= 0 */
 				printk(KERN_ERR BFX
 				       "0 vid exceeded with pstate %d\n", j);
+				kfree(ppst);
 				return -ENODEV;
 			}
 			if (ppst[j].vid < maxvid+rvo) { /* vid+rvo >= maxvid */
 				printk(KERN_ERR BFX
 				       "maxvid exceeded with pstate %d\n", j);
+				kfree(ppst);
 				return -ENODEV;
 			}
 		}
@@ -706,7 +708,7 @@
 
 		for (j = 0; j < numps; j++)
 			if ((ppst[j].fid==currfid) && (ppst[j].vid==currvid))
-				return (0);
+				return 0;
 
 		printk(KERN_ERR BFX "currfid/vid do not match PST, ignoring\n");
 		return 0;
Signature · 2 lines
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]