fix CONFIG_QFMT_V2 description
Subsystems (2)
PATCH 1/1 fix CONFIG_QFMT_V2 description
In 2,4, the CONFIG_QFMT_V2 short description talks about a "VFS v0 quota format". Is this really correct, or is the patch below that uses the "Quota format v2 support" text from 2.6 instead correct?
cu
Adrian
fs/Config.in renamed from fs/Config.in.old +1 -1
@@ -5,7 +5,7 @@ comment 'File systems' bool 'Quota support' CONFIG_QUOTA -dep_tristate ' VFS v0 quota format support' CONFIG_QFMT_V2 $CONFIG_QUOTA +dep_tristate ' Quota format v2 support' CONFIG_QFMT_V2 $CONFIG_QUOTA tristate 'Kernel automounter support' CONFIG_AUTOFS_FS tristate 'Kernel automounter version 4 support (also supports v3)' CONFIG_AUTOFS4_FS
Documentation/Configure.help renamed from Documentation/Configure.help.old +1 -1
@@ -13628,7 +13628,7 @@ <http://www.tldp.org/docs.html#howto>. Probably the quota support is only useful for multi user systems. If unsure, say N. -VFS v0 quota format support +Quota format v2 support CONFIG_QFMT_V2 This quota format allows using quotas with 32-bit UIDs/GIDs. If you need this functionality say Y here. Note that you will need latest
Quoted 3 lines · Adrian Bunk
In 2,4, the
CONFIG_QFMT_V2short description talks about a "VFS v0 quota format". Is this really correct, or is the patch below that uses the "Quota format v2 support" text from 2.6 instead correct?
I think you should ask Jan Kara instead what he prefers. This VFS v0 stuff is his invention. Personally I'm a little confused about the proper naming, too.
Quoted 8 lines · Christoph Hellwig
Quoted 3 lines · Adrian Bunk
In 2,4, the
CONFIG_QFMT_V2short description talks about a "VFS v0 quota format". Is this really correct, or is the patch below that uses the "Quota format v2 support" text from 2.6 instead correct?I think you should ask Jan Kara instead what he prefers. This VFS v0 stuff is his invention. Personally I'm a little confused about the proper naming, too.
Jan, could you check whether the patch below is correct?
TIA
Adrian
fs/Config.in renamed from fs/Config.in.old +1 -1
@@ -5,7 +5,7 @@ comment 'File systems' bool 'Quota support' CONFIG_QUOTA -dep_tristate ' VFS v0 quota format support' CONFIG_QFMT_V2 $CONFIG_QUOTA +dep_tristate ' Quota format v2 support' CONFIG_QFMT_V2 $CONFIG_QUOTA tristate 'Kernel automounter support' CONFIG_AUTOFS_FS tristate 'Kernel automounter version 4 support (also supports v3)' CONFIG_AUTOFS4_FS
Documentation/Configure.help renamed from Documentation/Configure.help.old +1 -1
@@ -13628,7 +13628,7 @@ <http://www.tldp.org/docs.html#howto>. Probably the quota support is only useful for multi user systems. If unsure, say N. -VFS v0 quota format support +Quota format v2 support CONFIG_QFMT_V2 This quota format allows using quotas with 32-bit UIDs/GIDs. If you need this functionality say Y here. Note that you will need latest
Jan Kara
reviewerQuoted 11 lines · Christoph Hellwig
Quoted 8 lines · Adrian Bunk
Quoted 3 lines
In 2,4, the
CONFIG_QFMT_V2short description talks about a "VFS v0 quota format". Is this really correct, or is the patch below that uses the "Quota format v2 support" text from 2.6 instead correct?I think you should ask Jan Kara instead what he prefers. This VFS v0 stuff is his invention. Personally I'm a little confused about the proper naming, too.
Jan, could you check whether the patch below is correct?
I don't have a strong opinion on this but I like the current state
slightly more. I know there's a mess that VFSv0 = quota_v2. But currently it's at least in the state that what users (admins) see is VFSv0 and v2 appears only in the name of kernel config options and in the identifiers in the code. Changing VFSv0 to "v2" in kernel is no problem but quota-tools use VFSv0 too and it's also used as an identifier of a quota format in the options of quota tools (hence renaming is higly unpleasant for admins). So I'm not sure that renaming config options in kernel doesn't make things even more messy.
Honza