Skip to contentSkip to conversation

[2.4] Remove ide bootup noise

PATCH In review Nuno Monteiro 2 participants 2 messages Jan 17, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 [2.4] Remove ide bootup noise

Hi Marcelo,

Recently, while syncing my local tree from 2.4.22 to 2.4.25-pre I found this little patchlet (back from the 2.4.20 days, AFAIR) that still applies and looks pertinent. I believe the original author is Erik Andersen, although I can't say for certain since I don't have the original email around anymore. Also, I seem to recall that Jens Axboe ok'ed it, but for whatever reason it never found its way into mainline.

This will remove the pointless boot message about wether or not the drive supports host protected area. Since we don't report any other drive capabilities this should go, as it' is just pointless noise. In 2.6 this was killed too. Also, this information can be obtained using 'hdparm'.

Please review and apply.

Regards,

Nuno

drivers/ide/ide-disk.c renamed from drivers/ide/ide-disk.c.orig +1 -4
@@ -1136,10 +1136,7 @@
  */
 static inline int idedisk_supports_host_protected_area(ide_drive_t *drive)
 {
-	int flag = (drive->id->cfs_enable_1 & 0x0400) ? 1 : 0;
-	if (flag)
-		printk("%s: host protected area => %d\n", drive->name, flag);
-	return flag;
+	return ((drive->id->cfs_enable_1 & 0x0400) ? 1 : 0);
 }
 
 /*
#1 lore raw
Quoted 8 lines · Nuno Monteiro

Hi Marcelo,

Recently, while syncing my local tree from 2.4.22 to 2.4.25-pre I found this little patchlet (back from the 2.4.20 days, AFAIR) that still applies and looks pertinent. I believe the original author is Erik Andersen, although I can't say for certain since I don't have the original email around anymore. Also, I seem to recall that Jens Axboe

Yup, that was me. I later submitted a follow-on patch that implemented proper hpa detection, which was accepted into 2.6.x, but never made it into 2.4,

-Erik

--
Erik B. Andersen http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--