Skip to contentSkip to conversation

IBM PowerPC Virtual Ethernet Driver

PATCH In review Santiago Leon 3 participants 4 messages Jan 19, 2004 – Jan 25, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 IBM PowerPC Virtual Ethernet Driver

Here's a patch that adds the inter-partition Virtual Ethernet driver for newer IBM iSeries and pSeries systems:

http://www-124.ibm.com/linux/patches/ppc64/ibmveth.patch

The patch applies against the 2.4.25-pre6 tree...

Jeff, can you formally add this driver to 2.4?... I'm waiting for some ppc64 architectural addition to send out the driver for 2.6...

Comments and suggestions are always welcome...

Signature · 3 lines
Santiago A. Leon
Power Linux Development
IBM Linux Technology Center
#1 lore raw
Quoted 6 lines · Santiago Leon

Here's a patch that adds the inter-partition Virtual Ethernet driver for newer IBM iSeries and pSeries systems:

http://www-124.ibm.com/linux/patches/ppc64/ibmveth.patch

The patch applies against the 2.4.25-pre6 tree...

Usually patches are subitted inline to ease review..

Quoted 2 lines

Jeff, can you formally add this driver to 2.4?... I'm waiting for some ppc64 architectural addition to send out the driver for 2.6...

I think we shouldn't accept new drivers in 2.4 anymore unless they're already in 2.6

#2 lore raw
Quoted 7 lines · Christoph Hellwig
Quoted 3 lines

http://www-124.ibm.com/linux/patches/ppc64/ibmveth.patch

The patch applies against the 2.4.25-pre6 tree...

Usually patches are subitted inline to ease review..

That was my original intention, however section 4, question 1 in the FAQ states:
"If your patch is on the large size (say larger than 500 lines) consider posting a URL pointing to the patch along with the patch description, instead of the whole patch." This patch was 1300+ lines.

Quoted 2 lines

I think we shouldn't accept new drivers in 2.4 anymore unless they're already in 2.6

Sure, it makes sense... I just wanted to get this driver out since the 2.4 tree has some architectural features that 2.6 doesn't have yet... I'm not sure how those features made it to 2.4 before 2.6 though!...

Signature · 3 lines
Santiago A. Leon
Power Linux Development
IBM Linux Technology Center
#3 lore raw
In reply to Christoph Hellwig
Quoted 7 lines · Christoph Hellwig
Quoted 2 lines · Santiago Leon

Jeff, can you formally add this driver to 2.4?... I'm waiting for some ppc64 architectural addition to send out the driver for 2.6...

I think we shouldn't accept new drivers in 2.4 anymore unless they're already in 2.6

The architectural dependency is queued for 2.6 and in 2.4, so I'm OK with it.

Jeff