Skip to contentSkip to conversation

Fix i2c busses warnings with DEBUG

PATCH New Jean Delvare 2 participants 2 messages May 19, 2005

Subsystems (3)
I2C subsystem host drivers I2C/smbus controller drivers for pc SCx200 CPU support
lore
Share & tools
lore

Jean Delvare

author
#0 lore raw

PATCH 1/1 Fix i2c busses warnings with DEBUG

Hi again Greg,

Two bus drivers (i2c-via and scx200_acb.c) generate warnings when the whole i2c subsystem is compiled with -DDEBUG. Suggested changes follow.

drivers/i2c/busses/i2c-via.c +1 -1
diff -ru linux-2.6.1-k1/drivers/i2c/busses/i2c-via.c linux-2.6.1-k3/drivers/i2c/busses/i2c-via.c
@@ -21,7 +21,7 @@
     Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
 */
 
-#define DEBUG
+/* #define DEBUG */
 
 #include <linux/kernel.h>
 #include <linux/module.h>
drivers/i2c/busses/scx200_acb.c +2 -4
diff -ru linux-2.6.1-k1/drivers/i2c/busses/scx200_acb.c linux-2.6.1-k3/drivers/i2c/busses/scx200_acb.c
@@ -47,9 +47,7 @@
 MODULE_PARM(base, "1-4i");
 MODULE_PARM_DESC(base, "Base addresses for the ACCESS.bus controllers");
 
-#define DEBUG 0
-
-#if DEBUG
+#ifdef DEBUG
 #define DBG(x...) printk(KERN_DEBUG NAME ": " x)
 #else
 #define DBG(x...)

@@ -374,7 +372,7 @@
 	if (rc = 0 && size = I2C_SMBUS_WORD_DATA && rw = I2C_SMBUS_READ)
 	    	data->word = le16_to_cpu(cur_word);
 
-#if DEBUG
+#ifdef DEBUG
 	printk(KERN_DEBUG NAME ": transfer done, result: %d", rc);
 	if (buffer) {
 		int i;
Signature · 2 lines
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/
Applied
#1 lore raw

PATCH 1/1 Fix i2c busses warnings with DEBUG

Quoted 4 lines · Jean Delvare

Hi again Greg,

Two bus drivers (i2c-via and scx200_acb.c) generate warnings when the whole i2c subsystem is compiled with -DDEBUG. Suggested changes follow.

Applied, thanks.

greg k-h