-mm5 has no i2c on amd64
PATCH 1/1 -mm5 has no i2c on amd64
Hi,
trivial fix ...
Gerd
==============================[ cut here ]==============================
arch/x86_64/Kconfig renamed from arch/x86_64/Kconfig.i2c +2 -0
@@ -429,6 +429,8 @@ source "drivers/char/Kconfig" +source "drivers/i2c/Kconfig" + source "drivers/misc/Kconfig" source "drivers/media/Kconfig"
Quoted 11 lines · Gerd Knorr
Hi,
trivial fix ...
Gerd
==============================[ cut here ]==============================
arch/x86_64/Kconfig line 435
Quoted 7 lines
arch/x86_64/Kconfig renamed from arch/x86_64/Kconfig.i2c +2
-0@@ -429,6 +429,8 @@ source "drivers/char/Kconfig" +source "drivers/i2c/Kconfig" + source "drivers/misc/Kconfig"
Ah-hah! That's why the ppc64 kbuild system is whining about undefined but used i2c symbols:
drivers/ieee1394/Kconfig:60:warning: enable is only allowed with boolean and tristate symbols drivers/media/video/Kconfig:13:warning: enable is only allowed with boolean and tristate symbols
So this change needs to be propagated to other architectures as well.
Quoted 21 lines · Andrew Morton
Quoted 10 lines
Hi,
trivial fix ...
Gerd
==============================[ cut here ]==============================
arch/x86_64/Kconfig line 435
Quoted 7 lines
arch/x86_64/Kconfig renamed from arch/x86_64/Kconfig.i2c +2
-0@@ -429,6 +429,8 @@ source "drivers/char/Kconfig" +source "drivers/i2c/Kconfig" + source "drivers/misc/Kconfig"Ah-hah! That's why the ppc64 kbuild system is whining about undefined but used i2c symbols:
Quoted 4 lines
drivers/ieee1394/Kconfig:60:warning: enable is only allowed with boolean and tristate symbols drivers/media/video/Kconfig:13:warning: enable is only allowed with boolean and tristate symbols
So this change needs to be propagated to other architectures as well.
The better approach is to use the generic drivers/Kconfig, as used by i386, parisc and cris today.
Sam
Quoted 11 lines · Gerd Knorr
Hi,
trivial fix ...
Gerd
==============================[ cut here ]==============================
arch/x86_64/Kconfig line 436
Quoted 8 lines
arch/x86_64/Kconfig renamed from arch/x86_64/Kconfig.i2c +2
-0@@ -429,6 +429,8 @@ source "drivers/char/Kconfig" +source "drivers/i2c/Kconfig" + source "drivers/misc/Kconfig" source "drivers/media/Kconfig"
Apparently architectures should be sourcing the generic drivers/Kconfig file. But let's run with your fix for now.