Skip to contentSkip to conversation

show "Fusion MPT device support" menu only if BLK_DEV_SD

PATCH In review Adrian Bunk 5 participants 7 messages Jan 20, 2004 – Jan 25, 2004

Subsystems (2)
SCSI LSI Logic MPT fusion drivers (FC/SAS/SPI)
lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 show "Fusion MPT device support" menu only if BLK_DEV_SD

With BLK_DEV_SD=n, I see a "Fusion MPT device support" menu I can't enter.

The simple patch below removes the "Fusion MPT device support" menu if BLK_DEV_SD=n.

Please apply
Adrian

drivers/message/fusion/Kconfig renamed from drivers/message/fusion/Kconfig.old +1 -1
@@ -1,9 +1,9 @@
 
 menu "Fusion MPT device support"
+	depends on BLK_DEV_SD
 
 config FUSION
 	tristate "Fusion MPT (base + ScsiHost) drivers"
-	depends on BLK_DEV_SD
 	---help---
 	  LSI Logic Fusion(TM) Message Passing Technology (MPT) device support
 	  provides high performance SCSI host initiator, and LAN [1] interface
#1 lore raw
Quoted 5 lines · Adrian Bunk

With BLK_DEV_SD=n, I see a "Fusion MPT device support" menu I can't enter.

The simple patch below removes the "Fusion MPT device support" menu if BLK_DEV_SD=n.

I'd rather see an explanation from LSI why a scsi LLDD depens on a uper driver. This can't be right.

#2 lore raw
Quoted 10 lines · Christoph Hellwig
Quoted 5 lines · Adrian Bunk

With BLK_DEV_SD=n, I see a "Fusion MPT device support" menu I can't enter.

The simple patch below removes the "Fusion MPT device support" menu if BLK_DEV_SD=n.

I'd rather see an explanation from LSI why a scsi LLDD depens on a uper driver. This can't be right.

There's a hint in the config help:

[2] In order enable capability to boot the linux kernel natively from a Fusion MPT target device, you MUST answer Y here! (currently requires CONFIG_BLK_DEV_SD)

But a kernel built with BLK_DEV_SD=n, FUSION=y builds and links OK.

#3 lore raw
Quoted 3 lines · Andrew Morton

[2] In order enable capability to boot the linux kernel natively from a Fusion MPT target device, you MUST answer Y here! (currently requires CONFIG_BLK_DEV_SD)

Well, that's true for any LLDD.

#4 lore raw
In reply to Andrew Morton
Quoted 7 lines · Andrew Morton

There's a hint in the config help:

[2] In order enable capability to boot the linux kernel natively from a Fusion MPT target device, you MUST answer Y here! (currently requires CONFIG_BLK_DEV_SD)

But a kernel built with BLK_DEV_SD=n, FUSION=y builds and links OK.

This is one of the patches I have in my tree. Andrew, shall I start feeding all my Kconfig cleanups through you rather than through kernel-janitors?

Signature · 6 lines
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain
#5 lore raw
Quoted 4 lines · Matthew Wilcox

Andrew, shall I start
feeding all my Kconfig cleanups through you rather than through kernel-janitors?

Doesn't Randy have some system going there?

#6 lore raw

On Sun, 25 Jan 2004 15:11:07 -0800 Andrew Morton <[email protected]> wrote:

| Matthew Wilcox <[email protected]> wrote:
| >
| > Andrew, shall I start
| >  feeding all my Kconfig cleanups through you rather than through
| >  kernel-janitors?
| 
| Doesn't Randy have some system going there?

Yes, some system, but I think that Matthew should go ahead and send this one to you.

--
~Randy